Improve try_get_params method
#260
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
approved these changes
May 4, 2025
sea-bass
reviewed
May 17, 2025
There was a problem hiding this comment.
Apologies for the delay -- I'm not really on these repos much these days.
Given this is a change in behavior, I don't feel like I should have the authority to make that decision. I'm going to leave this up to @pac48 as an original author of the package.
|
This was introduced with #205, but as discussed in the linked PR I think that it should have a different behavior. We could also deprecated the current one and add the proposed method with a different name if you prefer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only return true when the parameters are modified and return false for others cases
I've also modified it to use the unique_lock as it is much better than try_lock on the mutex itself.
Related to ros-controls/ros2_controllers#1198 (review)