Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Added explicit static_cast when converting to mt19937::result_type (uint_fast32_t) from:
Even though we're going from larger integers
to 32-bits, this is fine for random number generation seeding. The explicit cast makes this clearer in the code and removes the compiler warnings for implicit conversion.
The changes are in the test files: testHdSortedIds.cpp and testHdSortedIdsPerf.cpp, both of which still pass with the changes. I looked at the contribution and coding guidelines, if I overlooked something or there is a preferred way of implementing these changes, please let me know.
Link to proposal (if applicable)
Fixes Issue(s)
#3339
Checklist
[x] I have created this PR based on the dev branch
[x] I have followed the coding conventions
[ ] I have added unit tests that exercise this functionality (Reference:
testing guidelines)
[x] I have verified that all unit tests pass with the proposed changes
[x] I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)