Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version-placeholders #45

Closed
wants to merge 2 commits into from

Conversation

github-actions[bot]
Copy link

Prepare the release

  • If modified sync engine schema, double check the usage file only contains the final new definitions.
  • Prepare a pre-release in GitHub releases to generate a changelog.
    • Use this template.
    • Use the "Generate release notes" button to use an auto-generated changelog.
    • Add a summary to the top of the changelog.
    • Don't publish just yet!
  • Wait for CI to push the "release prep" commit.
    • Check merged manifest changes:
      • Check that no additional app permissions have been unintentionally added. This can occur when adding new dependencies or upgrading existing ones. If permissions have been added, check that these are actually required for the production version of the app before submitting and if so notify customer support of the change and reason for it.
      • Skim other changes to see if they are what you'd expect and there isn't anything eyebrow-raising.
    • Publish GitHub release you prepared above.
  • Post to #pocket-releases using the workflow pinned to the top of the channel.

Release on Google Play

  • Promote beta (open testing) to production.
    • Always update the release notes, because we don't want to keep the beta copy. If there is no prepared, agreed upon copy to call out new features, copy standard "bug fixes and improvements" notes from a previous production release.
    • Set rollout percentage (usually to 100%, in case of bigger/riskier releases to 10%, discuss with the team if you think it should be something else).
  • Release a new beta by promoting the internal test build to beta (open testing).
    • Copy previous beta release notes.
    • Check "Errors, warnings and messages". Google loves to put stuff in there that isn't really a problem, so there are "warnings" there we consistently ignore with each release. But, please, always check it to see if there isn't anything important this time.
    • Check changes between this and previous APK. (New App Bundles > Details (→ to the right of the new APK) > Changes tab)
    • Set rollout percentage to 100%.
  • Go to Publishing overview to send the changes for review.
    • Check the current Managed publishing setting. Keep if off to release as soon as it's through the review (e.g. when sending to review on the day of the release). Turn it on if preparing the release a day ahead and you want to manually release next morning.

After the release is live

  • Production
    • Post an update to #pocket-releases about the current rollout percentage.
    • Add the release to Confluence.
    • Create a PR of beta into prod using this template. Merge it (do not squash!).
  • Beta
    • Edit the GitHub release, uncheck "Set as a pre-release", check "Set as the latest release".
    • Merge this PR into beta (do not squash!).
    • Create a PR of beta into main using this template. Merge it (do not squash!).

@github-actions github-actions bot added the ignore-for-release Don't include this PR in automatically generated release notes. label Nov 12, 2024
@marcin-kozinski
Copy link
Collaborator

oops, shouldn't start feature branches with release- prefix or I should make the release PR workflow smarter. I guess this worked as QA for the update script 🤷

@marcin-kozinski marcin-kozinski deleted the release-version-placeholders branch November 12, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Don't include this PR in automatically generated release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant