This project is maintained again#11
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR represents a significant restructuring of the IntelliProcessor project, moving from the old org.polyfrost.sorbet.intelliprocessor package to org.polyfrost.intelliprocessor and reorganizing the codebase into more focused modules. The restructure includes migrating to newer versions of dependencies and improving code organization.
- Restructured package hierarchy from
sorbet.intelliprocessortointelliprocessor - Separated functionality into distinct modules (
editor,action,utils) - Updated dependencies including Gradle, Kotlin, and IntelliJ platform versions
Reviewed Changes
Copilot reviewed 29 out of 31 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| plugin.xml | Updated extension configurations and moved to new package structure |
| kotlin-plugin.xml | New configuration file for Kotlin-specific extensions |
| Multiple old files | Removed old implementation files from sorbet package |
| Multiple new files | Added new implementation files in reorganized package structure |
| gradle files | Updated dependency versions and build configuration |
| README.md | Minor formatting cleanup |
| .editorconfig | Changed indentation from tabs to spaces |
Comments suppressed due to low confidence (1)
src/main/kotlin/org/polyfrost/intelliprocessor/editor/PreprocessorKeywordCompletionContributor.kt:12
- The class name 'PreprocessorKeywordCompletion' doesn't match the filename 'PreprocessorKeywordCompletionContributor.kt'. Either rename the class to 'PreprocessorKeywordCompletionContributor' or rename the file to 'PreprocessorKeywordCompletion.kt'.
class PreprocessorKeywordCompletion : CompletionContributor(), DumbAware {
|
|
||
| fun get(file: PsiFile): String? { | ||
| val moduleDir = findModuleDirForFile(file) ?: run { | ||
| println("Module directory could not be found for file: ${file.virtualFile?.path}") |
There was a problem hiding this comment.
Using println() for error logging is not appropriate for production code. Consider using a proper logging framework or IDE notification system instead.
|
|
||
| val versionFile = moduleDir.toPath().resolve("versions/mainProject") | ||
| if (!Files.exists(versionFile)) { | ||
| println("Main project version file does not exist at: $versionFile") |
There was a problem hiding this comment.
Using println() for error logging is not appropriate for production code. Consider using a proper logging framework or IDE notification system instead.
Description
Project restructure. Also fixes a few long-time bugs.