Fix reported issues#12
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes two specific issues: preventing automatic appending of //$$ to newlines when unnecessary, and correcting syntax highlighting for non-if directives to ensure proper scope matching.
- Fixed logic in
PreprocessorNewLineHandlerto only insert preprocessor markers when inside conditional blocks - Refactored syntax highlighting to use proper visitor pattern for complete scope analysis
- Reorganized plugin configuration to support optional Java dependency and Kotlin K2 mode
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/resources/META-INF/plugin.xml | Moved Java-specific extensions to separate config file and made Java dependency optional |
| src/main/resources/META-INF/kotlin-plugin.xml | Reorganized Kotlin K2 support declaration to top of file |
| src/main/resources/META-INF/java-plugin.xml | New config file containing Java-specific plugin extensions |
| src/main/kotlin/org/polyfrost/intelliprocessor/editor/PreprocessorSyntaxHighlight.kt | Changed to use recursive visitor pattern for proper element traversal |
| src/main/kotlin/org/polyfrost/intelliprocessor/editor/PreprocessorNewLineHandler.kt | Added early return when no conditional blocks found and fixed block detection logic |
| gradle.properties | Version bump to 4.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
//$$automatically being appended to newlines undesirablyRelated Issue(s)
N/A
How to test
N/A
Release Notes
Documentation
N/A