Skip to content

feat: add-valkey engine#222

Merged
RambokDev merged 2 commits intomainfrom
feat/add-valkey
Mar 16, 2026
Merged

feat: add-valkey engine#222
RambokDev merged 2 commits intomainfrom
feat/add-valkey

Conversation

@RambokDev
Copy link
Collaborator

@RambokDev RambokDev commented Mar 16, 2026

Summary by CodeRabbit

  • New Features

    • Added Valkey as a supported database type with backup/restore capability and corresponding UI behavior.
  • Bug Fixes / UI

    • Database tab behavior adjusted so Valkey shows the backup-focused view where applicable.
  • Documentation

    • Updated README to list Valkey as a supported, stable option and revised the supported databases table.

@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

📝 Walkthrough

Walkthrough

Adds "valkey" as a recognized database type: updates the dbms_status enum and schema snapshot, adds a migration, and marks "valkey" as a backup-only DB in the dashboard tabs constant.

Changes

Cohort / File(s) Summary
DB enum & schema types
src/db/schema/types.ts
Added "valkey" to the dbms_status enum declaration used in the application schema.
Database migration
src/db/migrations/0039_conscious_solo.sql
Adds valkey to the PostgreSQL enum public.dbms_status via ALTER TYPE ... ADD VALUE.
Migration metadata / snapshot
src/db/migrations/meta/0039_snapshot.json, src/db/migrations/meta/_journal.json
Added migration snapshot (0039) and journal entry documenting the migration and schema state.
UI configuration
src/components/wrappers/dashboard/projects/database/database-tabs.tsx
Updated backupOnly constant to include valkey alongside redis, treating both as backup-only DB types in the dashboard UI.
Documentation
README.md
Added Valkey badge and updated Supported databases table to list Valkey as supported/stable and adjusted table headers/formatting.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • feat: add-redis #217: Modifies the same backupOnly constant and dbms_status enum additions, indicating an overlapping change to add backup-only DB types.

Poem

🐰 I hopped through enums and migration night,
Pushed "valkey" into schema light.
Tabs now whisper alongside Redis’ song,
Backups snug where they belong. 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and directly describes the main change—adding Valkey as a new database engine.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/add-valkey
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@README.md`:
- Around line 67-70: Replace the French conjunction "et" with the English "and"
in the README version ranges for the database entries; specifically update the
PostgreSQL "17 et 18" to "17 and 18", MySQL "8 et 9" to "8 and 9", MariaDB "10
et 11" to "10 and 11", and MongoDB "7 et 8" to "7 and 8" so the README uses
consistent English conjunctions across the "PostgreSQL", "MySQL", "MariaDB", and
"MongoDB" rows.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 25873615-2736-4bbf-8c1c-0c921c9ff2bd

📥 Commits

Reviewing files that changed from the base of the PR and between b0ce527 and d823ec2.

📒 Files selected for processing (1)
  • README.md
📜 Review details
🔇 Additional comments (1)
README.md (1)

24-24: Valkey badge addition looks correct.

Line 24 is consistent with the existing badge style and correctly links to Valkey’s official site.

@RambokDev RambokDev merged commit ae6dbca into main Mar 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant