Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

instrumentation using monkey patching and open telemetry #282

Merged
merged 6 commits into from
Feb 18, 2025
Merged

instrumentation using monkey patching and open telemetry #282

merged 6 commits into from
Feb 18, 2025

Conversation

narengogi
Copy link
Contributor

@narengogi narengogi commented Jan 21, 2025 •
edited
Loading

@narengogi narengogi marked this pull request as ready for review January 21, 2025 11:46
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 21, 2025
@narengogi
Copy link
Contributor Author

@csgulati09 @sk-portkey for your review

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jan 31, 2025
@narengogi narengogi changed the title initial commit for instrumentation using monkey patching and open telemetry instrumentation using monkey patching and open telemetry Feb 4, 2025
sk-portkey
sk-portkey previously approved these changes Feb 4, 2025
View reviewed changes
@dosubot dosubot bot added the lgtm label Feb 4, 2025
@csgulati09 csgulati09 self-requested a review February 12, 2025 11:35
csgulati09
csgulati09 reviewed Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@csgulati09 csgulati09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run:
make format
make lint
make build

I see there are a few formatting issues.

csgulati09
csgulati09 reviewed Feb 12, 2025
View reviewed changes
@narengogi
feat: auto-instrumentation
5c760ed 
initial commit for instrumentation using monkey patching and open telemetry

formatting and linting

Do not install dependencies for opentelemetry by default

version locking

make changes for async client

feat: instrumentation for litellm and openai

revert log changes

langgraph instrumentation

remove openai instrumentation

fix missing import

formatting

minor changes

minor fixes

fixes per comments
@narengogi narengogi force-pushed the feat/instrumentation branch from a34c45b to 5c760ed Compare February 13, 2025 06:35
@narengogi
fix: update check for installed package
e94d903 
fix: use Dict from typing instead of dict
@narengogi narengogi force-pushed the feat/instrumentation branch from 7e8b3c6 to e94d903 Compare February 13, 2025 06:55
@narengogi narengogi requested a review from csgulati09 February 13, 2025 08:10
csgulati09
csgulati09 requested changes Feb 15, 2025
View reviewed changes
@dosubot dosubot bot removed the lgtm label Feb 15, 2025
@narengogi narengogi requested a review from csgulati09 February 16, 2025 17:32
@narengogi narengogi force-pushed the feat/instrumentation branch from f978f6e to b553724 Compare February 16, 2025 17:36
csgulati09
csgulati09 requested changes Feb 17, 2025
View reviewed changes
@csgulati09 csgulati09 mentioned this pull request Feb 17, 2025
Open
@narengogi
Copy link
Contributor Author

made changes @csgulati09

@dosubot dosubot bot added the lgtm label Feb 18, 2025
@csgulati09 csgulati09 merged commit 1a359b3 into Portkey-AI:main Feb 18, 2025
6 checks passed
@csgulati09 csgulati09 linked an issue Feb 19, 2025 that may be closed by this pull request
Implement instrumentation for Agentic frameworks #283
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csgulati09 csgulati09 csgulati09 approved these changes

@sk-portkey sk-portkey sk-portkey left review comments

Assignees
No one assigned
Labels
auto:enhancement lgtm size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement instrumentation for Agentic frameworks
3 participants
@narengogi @csgulati09 @sk-portkey