Skip to content

Conversation

@ioannisj
Copy link
Contributor

@ioannisj ioannisj commented Oct 16, 2025

💡 Motivation and Context

Part of PostHog/posthog#38845
Needs PostHog/posthog#39738

Docs: PostHog/posthog.com#13356

CleanShot 2025-10-16 at 13 43 00

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

ablaszkiewicz
ablaszkiewicz previously approved these changes Oct 16, 2025
Copy link

@ablaszkiewicz ablaszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never seen dart before but looks legit

@ablaszkiewicz ablaszkiewicz dismissed their stale review October 16, 2025 11:14

I figured I should not be approving that

@ioannisj
Copy link
Contributor Author

Phew 😅 ~100 comments later.. i think i’ve covered most of it now. sorry for the chaos in this pr

@marandaneto
Copy link
Member

Phew 😅 ~100 comments later.. i think i’ve covered most of it now. sorry for the chaos in this pr

i hope they were valid and useful and not just nitty :)

@marandaneto
Copy link
Member

@ioannisj asked on the official docs but worth checking, do we need a guardrail for flutter web?

@ioannisj
Copy link
Contributor Author

Phew 😅 ~100 comments later.. i think i’ve covered most of it now. sorry for the chaos in this pr

i hope they were valid and useful and not just nitty :)

Of course they were, as always! Mille grazie!🙏

@ioannisj
Copy link
Contributor Author

@ioannisj asked on the official docs but worth checking, do we need a guardrail for flutter web?

Replied there PostHog/posthog.com#13356 (comment). Pushed a commit and now captureException is a noop on web

Question is, should we add support now? I'd have to see how this will play with js config options. We have the event data and props, so we may as well capture the event. My take is focus on mobile for now, then come back to web? wdyt?

@ioannisj
Copy link
Contributor Author

ioannisj commented Oct 24, 2025

@ioannisj asked on the official docs but worth checking, do we need a guardrail for flutter web?

Okay took a while but validated that web runs okay so worth including. Had a rough time with js interop but managed to figure it out thanx to this

Tested for default as well WebAssembly build modes.

When building with --wasm, I saw that some function names were leaking some PII. They had the shape of module0.InitialScreenState.build closure at file:///path/to/file.dart:251:30. Tried extracting just function name part in those cases. It might not catch every shape, but we can iterate once we see real world reports (this could even be just because of running locally maybe).

--no-wasm

CleanShot 2025-10-24 at 21 51 40@2x

--wasm

CleanShot 2025-10-24 at 23 11 09@2x

console

CleanShot 2025-10-24 at 23 11 44

@ioannisj
Copy link
Contributor Author

Will release this one and we can revisit on this comment if needed

@ioannisj ioannisj merged commit 88fddae into main Oct 31, 2025
6 checks passed
@ioannisj ioannisj deleted the feat/capture-exception branch October 31, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants