-
Notifications
You must be signed in to change notification settings - Fork 52
feat: add manual error capture #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
android/src/main/kotlin/com/posthog/flutter/PosthogFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never seen dart before but looks legit
I figured I should not be approving that
|
Phew 😅 ~100 comments later.. i think i’ve covered most of it now. sorry for the chaos in this pr |
i hope they were valid and useful and not just nitty :) |
|
@ioannisj asked on the official docs but worth checking, do we need a guardrail for flutter web? |
Of course they were, as always! Mille grazie!🙏 |
Replied there PostHog/posthog.com#13356 (comment). Pushed a commit and now captureException is a noop on web Question is, should we add support now? I'd have to see how this will play with js config options. We have the event data and props, so we may as well capture the event. My take is focus on mobile for now, then come back to web? wdyt? |
Okay took a while but validated that web runs okay so worth including. Had a rough time with js interop but managed to figure it out thanx to this Tested for default as well WebAssembly build modes. When building with --wasm, I saw that some function names were leaking some PII. They had the shape of --no-wasm
--wasm
console
|
This reverts commit 6c0529c.
|
Will release this one and we can revisit on this comment if needed |



💡 Motivation and Context
Part of PostHog/posthog#38845
Needs PostHog/posthog#39738
Docs: PostHog/posthog.com#13356
💚 How did you test it?
📝 Checklist