feat: event schema types #2445
feat: event schema types #2445
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| export function createTypedEventCapture<Client extends { capture: (event: string, properties?: any) => any }>( | ||
| client: Client | ||
| ): TypedEventCapture<Client> { | ||
| return new Proxy({} as TypedEventCapture<Client>, { |
There was a problem hiding this comment.
logic: Proxy is not supported in IE 11, which is listed in the browserslist. This will cause runtime errors in IE 11 environments when the typed property is accessed.
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/core/src/typed-events.ts
Line: 44:44
Comment:
**logic:** `Proxy` is not supported in IE 11, which is listed in the browserslist. This will cause runtime errors in IE 11 environments when the `typed` property is accessed.
How can I resolve this? If you propose a fix, please make it concise.| client: Client | ||
| ): TypedEventCapture<Client> { | ||
| return new Proxy({} as TypedEventCapture<Client>, { | ||
| get: (_target, eventName: string) => { |
There was a problem hiding this comment.
logic: The eventName parameter should be typed as string | symbol since Proxy get traps can receive Symbols (e.g., for well-known symbols like Symbol.toStringTag). Consider adding a type guard to filter out non-string property keys.
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/core/src/typed-events.ts
Line: 45:45
Comment:
**logic:** The `eventName` parameter should be typed as `string | symbol` since Proxy get traps can receive Symbols (e.g., for well-known symbols like `Symbol.toStringTag`). Consider adding a type guard to filter out non-string property keys.
How can I resolve this? If you propose a fix, please make it concise.
|
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Problem
Changes
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file