chore: react native chunk id #2484
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 No Changeset FoundThis PR doesn't include a changeset. A changeset (and the release label) is required to release a new version. How to add a changesetRun this command and follow the prompts: pnpm changesetRemember: Never use |
marandaneto
commented
Oct 22, 2025
| */ | ||
| def jscFlavor = 'io.github.react-native-community:jsc-android:2026004.+' | ||
|
|
||
| apply from: "../../node_modules/posthog-react-native/tooling/posthog.gradle" |
There was a problem hiding this comment.
this has to be done via wizard or manoelly
marandaneto
commented
Oct 22, 2025
| runOnlyForDeploymentPostprocessing = 0; | ||
| shellPath = /bin/sh; | ||
| shellScript = "if [[ -f \"$PODS_ROOT/../.xcode.env\" ]]; then\n source \"$PODS_ROOT/../.xcode.env\"\nfi\nif [[ -f \"$PODS_ROOT/../.xcode.env.local\" ]]; then\n source \"$PODS_ROOT/../.xcode.env.local\"\nfi\n\n# The project root by default is one level up from the ios directory\nexport PROJECT_ROOT=\"$PROJECT_DIR\"/..\n\nif [[ \"$CONFIGURATION\" = *Debug* ]]; then\n export SKIP_BUNDLING=1\nfi\nif [[ -z \"$ENTRY_FILE\" ]]; then\n # Set the entry JS file using the bundler's entry resolution.\n export ENTRY_FILE=\"$(\"$NODE_BINARY\" -e \"require('expo/scripts/resolveAppEntry')\" \"$PROJECT_ROOT\" ios absolute | tail -n 1)\"\nfi\n\nif [[ -z \"$CLI_PATH\" ]]; then\n # Use Expo CLI\n export CLI_PATH=\"$(\"$NODE_BINARY\" --print \"require.resolve('@expo/cli', { paths: [require.resolve('expo/package.json')] })\")\"\nfi\nif [[ -z \"$BUNDLE_COMMAND\" ]]; then\n # Default Expo CLI command for bundling\n export BUNDLE_COMMAND=\"export:embed\"\nfi\n\n# Source .xcode.env.updates if it exists to allow\n# SKIP_BUNDLING to be unset if needed\nif [[ -f \"$PODS_ROOT/../.xcode.env.updates\" ]]; then\n source \"$PODS_ROOT/../.xcode.env.updates\"\nfi\n# Source local changes to allow overrides\n# if needed\nif [[ -f \"$PODS_ROOT/../.xcode.env.local\" ]]; then\n source \"$PODS_ROOT/../.xcode.env.local\"\nfi\n\n`\"$NODE_BINARY\" --print \"require('path').dirname(require.resolve('react-native/package.json')) + '/scripts/react-native-xcode.sh'\"`\n\n"; | ||
| shellScript = "if [[ -f \"$PODS_ROOT/../.xcode.env\" ]]; then\n source \"$PODS_ROOT/../.xcode.env\"\nfi\nif [[ -f \"$PODS_ROOT/../.xcode.env.local\" ]]; then\n source \"$PODS_ROOT/../.xcode.env.local\"\nfi\n\n# The project root by default is one level up from the ios directory\nexport PROJECT_ROOT=\"$PROJECT_DIR\"/..\n\nif [[ \"$CONFIGURATION\" = *Debug* ]]; then\n export SKIP_BUNDLING=1\nfi\nif [[ -z \"$ENTRY_FILE\" ]]; then\n # Set the entry JS file using the bundler's entry resolution.\n export ENTRY_FILE=\"$(\"$NODE_BINARY\" -e \"require('expo/scripts/resolveAppEntry')\" \"$PROJECT_ROOT\" ios absolute | tail -n 1)\"\nfi\n\nif [[ -z \"$CLI_PATH\" ]]; then\n # Use Expo CLI\n export CLI_PATH=\"$(\"$NODE_BINARY\" --print \"require.resolve('@expo/cli', { paths: [require.resolve('expo/package.json')] })\")\"\nfi\nif [[ -z \"$BUNDLE_COMMAND\" ]]; then\n # Default Expo CLI command for bundling\n export BUNDLE_COMMAND=\"export:embed\"\nfi\n\n# Source .xcode.env.updates if it exists to allow\n# SKIP_BUNDLING to be unset if needed\nif [[ -f \"$PODS_ROOT/../.xcode.env.updates\" ]]; then\n source \"$PODS_ROOT/../.xcode.env.updates\"\nfi\n# Source local changes to allow overrides\n# if needed\nif [[ -f \"$PODS_ROOT/../.xcode.env.local\" ]]; then\n source \"$PODS_ROOT/../.xcode.env.local\"\nfi\n\n# `\"$NODE_BINARY\" --print \"require('path').dirname(require.resolve('react-native/package.json')) + '/scripts/react-native-xcode.sh'\"`\n\nset -e\n\n# RN 0.69 - 0.80.0\nWITH_ENVIRONMENT=\"../node_modules/react-native/scripts/xcode/with-environment.sh\"\nPOSTHOG_XCODE=\"../node_modules/posthog-react-native/tooling/posthog-xcode.sh\"\n\nBUNDLE_REACT_NATIVE=\"/bin/sh $POSTHOG_XCODE\"\n/bin/sh -c \"$WITH_ENVIRONMENT \\\"$BUNDLE_REACT_NATIVE\\\"\"\n"; |
There was a problem hiding this comment.
this has to be done via wizard or manoelly
marandaneto
commented
Oct 22, 2025
Comment on lines
+20
to
+26
| # TODO: when to call (inject): --release -- exp hermes inject --project my-app --directory $DERIVED_FILE_DIR | ||
| # TODO: what should i set for --project? | ||
|
|
||
| # TODO: when to call (clone): --release -- exp hermes clone --directory $DERIVED_FILE_DIR | ||
|
|
||
| # [ -z "$SOURCEMAP_FILE" ] && export SOURCEMAP_FILE="$DERIVED_FILE_DIR/main.jsbundle.map" | ||
| # TODO: is the CLI clever enough to pick the right file? there will be a bunch of non related files |
There was a problem hiding this comment.
figure out TODOs, same things on Android btw
|
Size Change: 0 B Total Size: 4.85 MB ℹ️ View Unchanged
|
marandaneto
commented
Oct 22, 2025
|
|
||
| exitCode=0 | ||
|
|
||
| # TODO: implement ALLOW_FAILURE CLI config to keep building if there are errors |
There was a problem hiding this comment.
implement easy CLI escape hatch otherwise the build will never succeed, eg no connection, posthog is down, etc
failing silently is also not a good option because that might mean a production release without source maps
so users could easily flip this flag to keep working temporarily
marandaneto
commented
Oct 22, 2025
|
|
||
| // bundleOutput and sourcemapOutput | ||
| def sourcemapDir = new File(sourcemapOutput).getParent() | ||
| args.addAll(["--release", "--", |
There was a problem hiding this comment.
afaict git info will be gotten automatically, this is cool but cannot be the only option
mobile has the concept of build variants, think of white label apps or uber driver vs uber client, paid vs free
the very same commit will generate multiple valid applications that have different code paths
so we will need to pass release info anyways
on mobile this would be the equivalent of a 'distribution'
eg an app namespace=com.posthog.app, version=1.0.0, build=1, distribution=paid
those distributions will generate different apps - consequently different sourcemaps
There was a problem hiding this comment.
we should use the project here which is not the same as posthog project, so we could let users set the project or we could concatenate our own dist project, as the example above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Relates to PostHog/posthog#39998
TODO:
Changes
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file