fix: session replay on react native web #2592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
marandaneto
requested review from
a team,
TueHaulund,
ksvat,
pauldambra and
veryayskiy
and removed request for
a team
Contributor
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 files reviewed, no comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
Contributor
|
Size Change: +2.26 kB (+0.04%) Total Size: 5.05 MB
ℹ️ View Unchanged
|
ioannisj
reviewed
Nov 18, 2025
| }, | ||
| }, | ||
|
|
||
| // persistence: 'memory', |
Member
Author
There was a problem hiding this comment.
no, just a handy comment to avoid reinstalling plugins https://posthog.com/docs/libraries/react-native#react-native-web-and-macos
ioannisj
reviewed
Nov 18, 2025
Comment on lines
+229
to
+231
| if (typeof File === 'undefined') { | ||
| ;(global as any).File = function () {} | ||
| } |
Contributor
There was a problem hiding this comment.
I wonder what functionality we may be dropping with this empty stub here? I assume rrweb uses this somehow
Member
Author
There was a problem hiding this comment.
its us
we do instanceof isFile, so this returns false on react native.
The feature impact:
- Session Recording Network Capture - PostHog won't be able to
properly serialize FormData containing File objects when recording
network requests- General HTTP requests - Any PostHog requests that include
FormData with files won't serialize correctlyWhat will happen without the polyfill:
- If FormData contains a File object, the isFile() check crashes
instead of returning false- The file would be converted to [object File] instead of the
filename- Session recording network capture may miss or incorrectly record
file upload requestsWith the File polyfill:
- isFile() returns false for all objects (since nothing is
actually a File in React Native)- Files get converted via .toString() instead of .name
- Session recording and requests work, but file names aren't
captured (graceful degradation)So the File polyfill ensures session recording and network
requests don't crash in React Native web, with minimal
functionality loss.
thats my friend "Claudio" :D
ioannisj
approved these changes
Nov 18, 2025
pauldambra
approved these changes
Nov 18, 2025
Member
pauldambra
left a comment
pauldambra
left a comment
There was a problem hiding this comment.
feels like the important thing here would be the docs on how to use this - but 🙌
Member
Author
agree, a good start would be to point out to the JS SDK tbh since its the very same thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
workaround for #2157
otherwise users would have to polyfill manually.
ideally users init the SDK conditionally, if mobile: uses the RN SDK, if web: uses the JS SDK
example: https://us.posthog.com/shared/6K26C6g8ljMoa0ZDOR9nJkXHchLHJg?t=4
Changes
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file