feat: better integration between llma and error tracking #2593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Contributor
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Additional Comments (8)
-
packages/ai/src/openai/index.ts, line 312-336 (link)logic: inconsistent error handling - still using old pattern
This error handler wasn't updated to use
sendEventWithErrorToPosthoglike the streaming paths were. This means it won't link exceptions to trace events and won't prevent double-capturing. -
packages/ai/src/openai/index.ts, line 504-529 (link)logic: inconsistent error handling - still using old pattern
Same as other non-streaming path, needs to be updated to
sendEventWithErrorToPosthog -
packages/ai/src/openai/index.ts, line 644-665 (link)logic: inconsistent error handling - still using old pattern
Same issue in embeddings error handler
-
packages/ai/src/anthropic/index.ts, line 285-304 (link)logic: inconsistent error handling - still using old pattern
This non-streaming error handler wasn't updated to use
sendEventWithErrorToPosthog -
packages/ai/src/openai/azure.ts, line 277-302 (link)logic: inconsistent error handling - still using old pattern
Azure OpenAI non-streaming error handlers also need the same update
-
packages/ai/src/openai/azure.ts, line 448-474 (link)logic: inconsistent error handling - still using old pattern
Another Azure OpenAI error handler that needs updating
-
packages/ai/src/openai/azure.ts, line 513-532 (link)logic: inconsistent error handling - still using old pattern
Another Azure OpenAI error handler that needs updating
-
packages/ai/src/openai/azure.ts, line 576-600 (link)logic: inconsistent error handling - still using old pattern
Azure embeddings error handler also needs updating
12 files reviewed, 9 comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
Contributor
|
Size Change: +5.12 kB (+0.1%) Total Size: 5.05 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Inspired by this thread: https://posthog.slack.com/archives/C07AA937K9A/p1759356822031919
Changes
isErrorcheck given we have the errorRelease info Sub-libraries affected
Libraries affected