Skip to content

chore: upload wizard artifacts to s3#941

Open
joshsny wants to merge 3 commits intomainfrom
js/upload-artifacts-to-s3
Open

chore: upload wizard artifacts to s3#941
joshsny wants to merge 3 commits intomainfrom
js/upload-artifacts-to-s3

Conversation

@joshsny
Copy link
Copy Markdown

@joshsny joshsny commented Mar 20, 2026

Summary

  • Adds OIDC-based AWS credential configuration to the wizard-ci workflow
  • Uploads wizard CI artifacts (output logs, context-mill resources, skills resources, YARA reports) to an S3 bucket
  • Artifacts are organized by trigger ID and app name: s3://<bucket>/<trigger-id>/<app-name>/
  • Uses continue-on-error: true so S3 upload failures don't break the CI run

Setup required

After the corresponding posthog-cloud-infra PR is applied, three secrets need to be added to this repo:

  • AWS_WIZARD_ARTIFACTS_ROLE_ARN — the IAM role ARN from terraform output
  • AWS_WIZARD_ARTIFACTS_REGIONus-east-1
  • AWS_WIZARD_ARTIFACTS_BUCKETposthog-wizard-artifacts-prod-us

Test plan

  • Infra PR is applied first to create the S3 bucket and IAM role
  • Secrets are configured in wizard-workbench repo settings
  • Run a wizard-ci workflow and verify artifacts appear in S3 under the expected path

🤖 Generated with Claude Code

joshsny and others added 3 commits March 20, 2026 20:58
Add OIDC-based AWS credential configuration and S3 upload steps to the
wizard-ci workflow. Artifacts (wizard output logs, context-mill resources,
skills resources, YARA reports) are uploaded to an S3 bucket organized by
trigger ID and app name.

Requires three secrets to be configured:
- AWS_WIZARD_ARTIFACTS_ROLE_ARN
- AWS_WIZARD_ARTIFACTS_REGION
- AWS_WIZARD_ARTIFACTS_BUCKET

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
GitHub artifacts on a public repo are accessible to anyone.
Since these contain CI output that should be private, remove
the upload-artifact steps and rely solely on S3.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@joshsny joshsny changed the title Upload wizard CI artifacts to S3 chore: upload wizard artifacts to s3 Mar 20, 2026
@joshsny joshsny requested a review from a team March 20, 2026 21:25
Copy link
Copy Markdown
Contributor

@gewenyu99 gewenyu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! We do just need to add the log file to this, tho. I think these suggestions work :squint:

TRIGGER_ID="${{ needs.discover.outputs.trigger_id }}"
SAFE_APP="${{ matrix.app }}"
SAFE_APP="${SAFE_APP//\//-}"
S3_PREFIX="s3://${{ secrets.AWS_WIZARD_ARTIFACTS_BUCKET }}/${TRIGGER_ID}/${SAFE_APP}"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trigger ID is a UID yah?


aws s3 cp wizard-output.log "${S3_PREFIX}/wizard-output.log" || true
aws s3 cp context-mill-mcp-resources.zip "${S3_PREFIX}/context-mill-mcp-resources.zip" || true
aws s3 cp skills-mcp-resources.zip "${S3_PREFIX}/skills-mcp-resources.zip" || true
Copy link
Copy Markdown
Contributor

@gewenyu99 gewenyu99 Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
aws s3 cp skills-mcp-resources.zip "${S3_PREFIX}/skills-mcp-resources.zip" || true
aws s3 cp wizard-log.log "/tmp/posthog-wizard.log" || true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants