remove(feat): fail schema cache lookup with invalid db-schemas config #4418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes PostgREST#4364 by reverting 86c3257 As discussed on PostgREST#4364, 86c3257 generates several problems: 1)We diverge from database as source of truth because once a schema is dropped, it's not automatically removed from `db-schemas` and then postgREST fails. 2)We diverge from PostgreSQL `search_path` lenient behavior: ```sql set search_path to anything, here, even, nonexistent; -- this doesn't fail ``` 3)schema-based multitenancy becomes more complicated because of 1. There are no noticeable gains from 86c3257: - No gains in performance for the schema cache queries. - No user report about it ever being a problem. In fact the leniency was a feature.
steve-chavez
force-pushed
the
rev-schema-fail
branch
from
20880c7 to
3db0561
Compare
|
I don't have the energy to fight about this, so I won't block you, but I also won't approve a change that I think is fundamentally wrong.
This is just backwards. With this change, the schema cache becomes the source of truth. Schema still in the schema cache? You get a 200 OK. That's not the database as the source of truth. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4364 by reverting 86c3257
As discussed on #4364, 86c3257 generates several problems:
db-schemasand then postgREST fails. Reducing its reliability.search_pathlenient behavior:There are no noticeable gains from 86c3257:
Implementation details
Essentially it removes the
$1::regnamespace[]casting fordb-schemasthat was introduced on 86c3257