(GH-538) Use derive macro for DscRepoSchema trait
#1310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeltlombardi
force-pushed
the
gh-538/main/dsc_repo_schema_trait_macro
branch
from
786f5b3 to
56ade57
Compare
Prior to this change, adding the `DscRepoSchema` trait to any type required manual implementation. This change: - Defines a new `dsc-lib-jsonschema-macros` crate to publish procedural macros related to JSON Schemas. - Defines a derive macro for the `DscRepoSchema` trait. - Provides integration testing for the new macro. This change doesn't migrate the implementations for the `DscRepoSchema` trait from manual to macro-derived in `dsc-lib`. Those changes should follow separately.
Prior to this change, the resource manifest, extension manifest, and configuration document structs in `dsc-lib` manually implemented the `DscRepoSchema` trait. This change uses the new macro to derive the trait on those types and other types in the library that currently map to schema files. This change also makes an effort to correctly annotate types that aren't covered by the separate schemas, but as not all types map to a schema file, these changes don't fully cover all types that derive the `JsonSchema` trait. This change prepares the library for further canonicalization steps to steer the generated schemas towards the definitions in the canonical schemas.
michaeltlombardi
force-pushed
the
gh-538/main/dsc_repo_schema_trait_macro
branch
from
56ade57 to
136c9f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Important
This PR depends on #1309 and will remain in draft until that PR is merged.
Prior to this change, the resource manifest, extension manifest, and configuration document structs in
dsc-libmanually implemented theDscRepoSchematrait.This change uses the new macro to derive the trait on those types and other types in the library that currently map to schema files. This change also makes an effort to correctly annotate types that aren't covered by the separate schemas, but as not all types map to a schema file, these changes don't fully cover all types that derive the
JsonSchematrait.This change prepares the library for further canonicalization steps to steer the generated schemas towards the definitions in the canonical schemas.
PR Context
dsc schemacommand #538