-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vi-mode] Supports 'diw' text-object command. #2059
Conversation
24dbaa4
to
c8cf272
Compare
@springcomp I resolved the conflicts. Will finish the review tonight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can we have it exposed to |
Unfortunately, that PR has been merged a bit too quickly. I addressed feedback from follow up conversations in a future pull request that addresses this shortcomings. |
PR Summary
Fixes #2057.
This PR is a first attempt at supporting text-objects in vi-mode. It includes a reasonably complete implementation of the diw command.
Although I have worked hard to make this PR production ready, it must still be considered WIP. I would really appreciate feedback about the implementation.
If this is deemed interesting enough, it could be the first step towards a much complete set of pull requests as alluded to in #584.
PR Checklist
Microsoft Reviewers: Open in CodeFlow