Improved reliability of some tests #4686
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
TL;DR;
This pull request suggests an improvement to the
TestSetup()
method to initialize some data members that are used in some tests that would otherwise fail.Summary
Some tests around history, prediction and suggestion – are failing on the local machine due to the
PSConsoleReadLine._history
member not being initialized.This member is initialized the first time the
PSConsoleReadLine.ReadLine()
method is called, which happens in theTest
method overloads.However, some tests perform actions between the
TestSetup()
and theTest()
methods. For instance, the following test fails because the_history
member is not initialized:List_RenderSuggestion_UpdatesWhileTyping:
PR Checklist
Microsoft Reviewers: Open in CodeFlow