Name the missing folders when climate data is incomplete - #23
Open
eliotmcintire wants to merge 1 commit into
Open
Name the missing folders when climate data is incomplete#23eliotmcintire wants to merge 1 commit into
eliotmcintire wants to merge 1 commit into
Conversation
prepClimateLayers() stopped with "all(dir.exists(allDirs)) is not TRUE", which does not say which folders are missing. Now it names the tile and the folders, and notes that the downloaded archive may not contain them. Seen with tile 39: the 2010s CNRM-ESM2-1 ssp370 archive contains only 2011, 2012 and 2017-2019. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017gZhFo9aCTrEgMVrP37sUo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small change to make one error easier to act on.
When an expected climate data folder isn't there,
prepClimateLayers()currently stops withall(dir.exists(allDirs)) is not TRUE, which doesn't say what is missing. This replaces it with a message that names the tile and the folders:We ran into this with tile 39:
39_CNRM-ESM2-1_370_MSY_2010.zipon Drive only contains 2011, 2012 and 2017–2019. The other tile 39 archives for that decade that we checked (ssp245 and ssp585 all-variables, ssp370 monthly and yearly) are complete. Happy to share more detail if it helps.A small test is included. Thank you for taking a look.
🤖 Generated with Claude Code
https://claude.ai/code/session_017gZhFo9aCTrEgMVrP37sUo