Initiate new discount types table in 9.1.0

[boherm]

Questions	Answers
Description?	Initiate new discount types table in 9.1.0
Type?	improvement
BC breaks?	no
Deprecations?	no
Fixed ticket?	~
Sponsor company	PrestaShop SA
How to test?	Upgrade into 9.1.0 version

[jolelievre]

Thanks @boherm

[Hlavtox]

Two things:

1. These translations won't be discoverable, are you sure they will be scannned?

2. I see cart rule compatibility that only resolves compatibility types, this is not enough and it was promised that this will be resolved no?

[boherm]

Hi @Hlavtox,

1. We have create a CartRuleTypeLang.php in classes/lang/KeysReference (like we do for others things) to discover some translations. (as you see here, the translation tool can discover this new strings)

2. I can't answer to this, but maybe @ibahloul-ps or @jolelievre could 😜

1. yep don't worry these wordings have been correctly scanned
2. this question is not relevant with the upgrade PR, the new system is indeed based on incompatibility based on types, the purpose is to find alternatives to the current system that creates a compatibility table that is exponentially getting bigger Maybe it's not enough, but that's what the experimental phase is made for and that's why we need the comunity to test this new discount feature

[Hlavtox]

@jolelievre Yeah, but by pushing this to 9.1 you create a BC break contract that you cannot take back.

Maybe it's not enough, but that's what the experimental phase is made for and that's why we need the comunity to test this new discount feature

So you are implementing something, completely breaking up the discount system and you don't know if it's gonna work? Is this for real?

[Quetzacoalt91]

@boherm what's the related PR on PrestaShop/PrestaShop repository?

[jolelievre]

@Hlavtox stop the drama! This is fully retro compatible with the current system
How is it a breaking change?

[Hlavtox]

@jolelievre It's not, in the current system, you define cart rule compatibility with specific cart rules.

In your new "improved" system (a.k.a we removed some functionality), it's only defined by cart rule types.

If you push it now, you cannot take it back, if you don't want to piss developers who already started preparing solutions and modules for it.

And then you openly admit: Maybe it’s not enough, but that’s what the experimental phase is for and why we need the community to test this new discount feature. I thought there was a huge amount of exploration behind this with highly esteemed French merchants?

What kind of design is this, where discount compatibility is defined only by the rule type? So a discount is either incompatible with everything, or compatible with everything? What kind of nonsense is that?

[jolelievre]

The new system is behind a feature flag, it doesn't prevent the current system from working as long as you don't enable the new feature The purpose is indeed to test things and see if it meets the needs, if it doesn't the feature can still evolve And if we realize the cart rule types are a bad iea we can still remove them from the DB, since they are related to an experimental feature it's still possible without a BC

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[AureRita]

Hi @boherm

Thank you for your PR, I tested it and it seems to works as you can see :

Capture.video.du.2026-01-07.18-07-30.mp4

Tested from :
8.1.4 to 9.1.0
9.0.2 to 9.1.0

Because the PR seems to works as expected, It's QA ✔️

Waiting for CLI green to remove the waiting QA

Thank you

[boherm]

Hi @Quetzacoalt91,
As asked, this PR is made for this three PRs about new discount system:

• Add discount compatibility PrestaShop#39662
• Create fixtures for discount types PrestaShop#40293
• Discount minimal cart product PrestaShop#38842