Skip to content

Listen on IPv6 - #178

Open
Clap404 wants to merge 2 commits into
PrestaShop:mainfrom
Clap404:feat/ipv6-listeners
Open

Listen on IPv6#178
Clap404 wants to merge 2 commits into
PrestaShop:mainfrom
Clap404:feat/ipv6-listeners

Conversation

@Clap404

@Clap404 Clap404 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Add listen [::]:80 and listen [::]:443 so flashlight is usable in ipv6 enabled environments.

Questions Answers
Description? enable ipv6 support for prestashop-flashlight
Type? improvement
BC breaks? no
Deprecations? no
Sponsor company Prestashop

@github-project-automation github-project-automation Bot moved this to Ready for review in PR Dashboard Jun 16, 2026
@Clap404
Clap404 force-pushed the feat/ipv6-listeners branch from 8a5738a to 9bea0d0 Compare June 16, 2026 13:05
@sonarqubecloud

Copy link
Copy Markdown

@matks matks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello it is probably a good idea but there is one thing check:

alpine-base-install.sh has a workaround for newer nginx versions that don't support the http2 keyword inside listen directives
https://github.com/PrestaShop/prestashop-flashlight/blob/main/assets/alpine-base-install.sh#L42

it removes listen 443 ssl http2; and replaces it with separate listen 443 ssl; and http2 on; lines.

But the search-and-replace only targets the exact string

Suggestion fix it, the same sed logic in alpine-base-install.sh should also handle listen [::]:443 ssl http2; and you need to add a # listen [::]:443 ssl; commented line in nginx.conf as fallback equivalent for IPv6.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

4 participants