Skip to content

Better GDPR data export#113

Open
pszostok wants to merge 1 commit intoPrestaShop:devfrom
pszostok:FIX-1
Open

Better GDPR data export#113
pszostok wants to merge 1 commit intoPrestaShop:devfrom
pszostok:FIX-1

Conversation

@pszostok
Copy link

Questions Answers
Description? There are two places where we retrieve the subscriber list, but the code inside hookActionExportGDPRData is too basic and doesn't handle all cases. As a result, we get inconsistent data — on the subscribers page in the BO, we see that a user has subscribed to the newsletter, but when downloading personal information via the psgdpr module (which uses hookActionExportGDPRData), some data are missing. It's also problematic to have two blocks of code doing the same thing.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? none
How to test? Change the newsletter setting on the customer page in the BO, and then download the personal data using the psgdpr module. With the old code, it will not retrieve any results related to the newsletter, even though the module's BO page shows the user as a subscriber.

@ps-jarvis
Copy link

Hello @pszostok!

This is your first pull request on ps_emailsubscription repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

3 participants