fix: create icon_paths field for communities#410
Open
suprstarrd wants to merge 1 commit intoPretendoNetwork:devfrom
Open
fix: create icon_paths field for communities#410suprstarrd wants to merge 1 commit intoPretendoNetwork:devfrom
icon_paths field for communities#410suprstarrd wants to merge 1 commit intoPretendoNetwork:devfrom
Conversation
This allows subcommunities to have their own icons, and also allows for more granular control over where icons exist in the future. There are a few minor but more complicated exceptions where this addition is not respected yet. Signed-off-by: Sienna "suprstarrd" M. <business@suprstarrd.com>
suprstarrd
force-pushed
the
fix/subcommunity-icons
branch
from
780a0a4 to
ecb90b8
Compare
mrjvs
requested changes
Mar 8, 2026
| }, | ||
| ctr_header: { type: String }, | ||
| wup_header: { type: String }, | ||
| icon_paths: { |
Contributor
There was a problem hiding this comment.
I'm not a 100% sure but I think mongoose will fill in this object for existing db entries. So itll make it always truthy.
If you could test if this works as expected (not break) with existing db entries that don't have icons. that'd be grand
Contributor
There was a problem hiding this comment.
Also with communities created by miiverse-api, it should be nullable, right?
Games don't upload icons, so it'd have to inherit the parent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #407 and is related to #87 and #268
Changes:
This commit adds an
icon_pathsfield for communities and puts it in use if it exists for a certain community. This allows subcommunities to have their own icons, and also allows for more granular control over where icons exist in the future.There are a few minor but more complicated exceptions where this addition is not respected yet.
Had to pull this out of a few other unrelated changes (which are now in separate branches on my fork) so if anything seems out of place, let me know so I can pluck it. That's where it comes from.