Merged
Conversation
Requesting a split depth render results in getting two renders in one image, the top half having the back half of the Mii head (usually the hair) and then the bottom half having the front half. This is needed for the Mii editor because it's drawing the body manually, and you want some elements of the head (hair) to be behind the body and the rest to be in front. Previously, it solved this problem by loading a copy of the Mii head that's bald, but this along with other stuff added up to four Mii Studio requests on every render - now it's just one. NOTE!!!!: This actually doesn't handle importing mii-js from the new TypeScript project, so as of this commit it WILL NOT work - installing the new repo, which this doesn't even reference, doesn't produce compiled JS from the TS source, so it will simply not import.
Reduce Mii editor HTTP requests from 4 to 1 on every change
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge dev into master