-
Notifications
You must be signed in to change notification settings - Fork 31
Selective Variable Submission in Screens #1872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Selective Variable Submission in Screens
caleeli
approved these changes
Nov 21, 2025
screen-builder
|
|||||||||||||||||||||||||||||||||||||||||||
| Project |
screen-builder
|
| Branch Review |
feature/FOUR-27781
|
| Run status |
|
| Run duration | 15m 31s |
| Commit |
|
| Committer | Rodrigo Quelca |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
3
|
|
|
0
|
|
|
19
|
|
|
0
|
|
|
386
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
FormTextArea.spec.js • 2 failed tests • CI - Chrome
| Test | Artifacts | |
|---|---|---|
| Form Text Area Field > Aria Label |
Test Replay
Screenshots
|
|
| Form Text Area Field > Tab Order |
Test Replay
Screenshots
|
|
Task.spec.js • 1 failed test • CI - Chrome
| Test | Artifacts | |
|---|---|---|
| Task component > Subprocess without pending task should redirect to parent request |
Test Replay
Screenshots
|
|
…displaying in the warning message
FOUR-28125: Submit information (enable/disable) does not have the same figma design
|
caleeli
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.





Solution
How to Test
Related Tickets & Packages
Code Review Checklist
Note
Adds a submit-button UI to select variables to send and a filtering mixin that narrows submission payloads to those variables (preserving system vars), with tests and tooling updates.
VariablesToSubmitinspector component (src/components/inspector/variables-to-submit.vue) and export ininspector/index.js.src/components/accordions.js) and wire in form builder controls (src/form-builder-controls.js).FormButtonnow includesconfig.variablesToSubmitin emittedbuttonInfo(src/components/renderer/form-button.vue).VariablesToSubmitFilter(src/mixins/VariablesToSubmitFilter.js) filtersdatato selected variables and always preserves system keys (_...).ScreenBase,VueFormRenderer, andJson2Vue;submitFormnow emits filteredeventDatainstead of full model.task.vueensures non-nullformDataand passes it through on submit.VariablesToSubmit(src/stories/VariablesToSubmit.stories.js).tests/unit/VariablesToSubmit.spec.js).package.json: add Jest scripts and deps (babel-jest,vue-jest,jest-*).Written by Cursor Bugbot for commit 570d9b5. This will update automatically on new commits. Configure here.