Skip to content

Conversation

@rodriquelca
Copy link
Contributor

@rodriquelca rodriquelca commented Nov 21, 2025

Solution

  • Selective Variable Submission in Screens was imprroved
image

How to Test

  • Create a screen
  • Add a submit button
  • Select submit button
  • Go to advanced
  • Enable Submit Information
  • Select the variables

Related Tickets & Packages

  • Link to any related FOUR tickets, PRDs, or packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Note

Adds a submit-button UI to select variables to send and a filtering mixin that narrows submission payloads to those variables (preserving system vars), with tests and tooling updates.

  • Selective submission UI
    • Add VariablesToSubmit inspector component (src/components/inspector/variables-to-submit.vue) and export in inspector/index.js.
    • Expose property in advanced settings (src/components/accordions.js) and wire in form builder controls (src/form-builder-controls.js).
    • FormButton now includes config.variablesToSubmit in emitted buttonInfo (src/components/renderer/form-button.vue).
  • Submit flow filtering
    • New mixin VariablesToSubmitFilter (src/mixins/VariablesToSubmitFilter.js) filters data to selected variables and always preserves system keys (_...).
    • Apply mixin in ScreenBase, VueFormRenderer, and Json2Vue; submitForm now emits filtered eventData instead of full model.
    • task.vue ensures non-null formData and passes it through on submit.
  • Stories/Tests
    • Add Storybook stories for VariablesToSubmit (src/stories/VariablesToSubmit.stories.js).
    • Add unit tests for filtering logic (tests/unit/VariablesToSubmit.spec.js).
  • Tooling
    • package.json: add Jest scripts and deps (babel-jest, vue-jest, jest-*).

Written by Cursor Bugbot for commit 570d9b5. This will update automatically on new commits. Configure here.

@rodriquelca rodriquelca changed the title Feature/four 27781 Selective Variable Submission in Screens Nov 21, 2025
@cypress
Copy link

cypress bot commented Nov 21, 2025

screen-builder    Run #2125

Run Properties:  status check failed Failed #2125  •  git commit 303587025c: Selective Variable Submission in Screens
Project screen-builder
Branch Review feature/FOUR-27781
Run status status check failed Failed #2125
Run duration 15m 31s
Commit git commit 303587025c: Selective Variable Submission in Screens
Committer Rodrigo Quelca
View all properties for this run ↗︎

Test results
Tests that failed  Failures 3
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 386
View all changes introduced in this branch ↗︎

Tests for review

Failed  FormTextArea.spec.js • 2 failed tests • CI - Chrome

View Output

Test Artifacts
Form Text Area Field > Aria Label Test Replay Screenshots
Form Text Area Field > Tab Order Test Replay Screenshots
Failed  Task.spec.js • 1 failed test • CI - Chrome

View Output

Test Artifacts
Task component > Subprocess without pending task should redirect to parent request Test Replay Screenshots

@rodriquelca rodriquelca requested a review from caleeli November 21, 2025 19:15
@processmaker-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@nolanpro nolanpro merged commit 11e251f into develop Dec 2, 2025
11 of 17 checks passed
@nolanpro nolanpro deleted the feature/FOUR-27781 branch December 2, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants