JavaFX_GUI #257
Open
JavaFX_GUI #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…printing. Set grids for exits
Contributor
|
Done: https://github.com/Progether/JAdventure/tree/JavaFX_GUI I haven't had a chance to review this yet, so I'll leave the PR open. Thanks for your work! |
jfullstackdev
left a comment
jfullstackdev
left a comment
There was a problem hiding this comment.
I suggest you don't create a pull request in progress. That's actually a bad practice. Rather, you create small changes with certain focus. Just like what happened, the changes ended up with merge conflicts that we don't want to happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress for a JavaFX GUI with the use of SceneBuilder.
Please merge it in a new branch (JavaFX_GUI) so more people can contribute.
#204