Updates for Pytorch 2.7 #8429

ericspod · 2025-04-25T11:38:48Z

Description

This will update MONAI to be compatible with PyTorch 2.7. There appear to be few code changes with this release so hopefully this will be simply a matter of updating versions.

Types of changes

Non-breaking change (fix or new feature that would not break existing functionality).
Breaking change (fix or new feature that would cause existing functionality to change).
New tests added to cover the changes.
Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
In-line docstrings updated.
Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Eric Kerfoot <[email protected]>

Copilot

Pull Request Overview

This PR updates MONAI’s torch dependency to a newer version aiming for improved compatibility with PyTorch. The changes include:

Increasing the minimum torch version in pyproject.toml from 2.3.0 to 2.4.1.
Updating the installation command in the GitHub Actions workflow (pythonapp.yml) accordingly.
Modifying the torch version matrix in the minimal workflow (pythonapp-min.yml).

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 3 comments.

File	Description
pyproject.toml	Updated minimum torch dependency and Black target versions
.github/workflows/pythonapp.yml	Updated torch installation command to new dependency
.github/workflows/pythonapp-min.yml	Revised torch version matrix for testing

Files not reviewed (2)

docs/requirements.txt: Language not supported
setup.cfg: Language not supported

pyproject.toml

.github/workflows/pythonapp.yml

.github/workflows/pythonapp-min.yml

Signed-off-by: Eric Kerfoot <[email protected]>

pyproject.toml

Signed-off-by: Eric Kerfoot <[email protected]>

ericspod · 2025-04-25T13:01:42Z

It's possible the CPU provided by the Windows runner is too old for PyTorch 2.7 which may now require instructions it doesn't have.

ericspod · 2025-04-25T22:01:32Z

The issue with Windows appears to be related to float 64 calculations, specifically with RandRotate in tests\integration\test_pad_collation.py. This doesn't appear to be pad collation related and goes away if float 32 is used as the dtype. I'm investigating further.

ericspod · 2025-04-28T23:54:37Z

I think I've traced the issue to apparently a bug in grid_sample, I've raised an issue here on the PyTorch repo.

KumoLiu · 2025-04-29T13:14:02Z

I think I've traced the issue to apparently a bug in grid_sample, I've raised an issue here on the PyTorch repo.

Thank you for looking into this! Instead of waiting for a fix from PyTorch, do you think it's possible to implement a workaround by altering the dtype for Windows operating systems?

ericspod · 2025-04-29T13:18:43Z

do you think it's possible to implement a workaround by altering the dtype for Windows operating systems?

I'm looking into that now and will hopefully have something soon. We may have to convert to float32 and back in places so we may have knock-on precision issues.

KumoLiu · 2025-04-30T07:10:17Z

We may need waiting for the release from torch-tensorrt to support PyTorch2.7.
https://pypi.org/project/torch-tensorrt/#history

Signed-off-by: Eric Kerfoot <[email protected]>

for more information, see https://pre-commit.ci

…uld be removed when PyTorch is updated. Signed-off-by: Eric Kerfoot <[email protected]>

for more information, see https://pre-commit.ci

Signed-off-by: Eric Kerfoot <[email protected]>

ericspod · 2025-05-01T23:43:11Z

Hi @KumoLiu this got through the Windows tests now. I raised the issue with PyTorch so hopefully version 2.7.1 will resolve the issue, in the meantime we can run the blossom tests and discuss whether to merge this.

Signed-off-by: Eric Kerfoot <[email protected]>

KumoLiu · 2025-05-02T04:58:48Z

/build

KumoLiu · 2025-05-02T10:24:43Z

Error log:

[2025-05-02T05:07:25.738Z]   Attempting uninstall: setuptools
[2025-05-02T05:07:25.738Z]     Found existing installation: setuptools 45.2.0
[2025-05-02T05:07:25.738Z]     Uninstalling setuptools-45.2.0:
[2025-05-02T05:07:25.738Z]       Successfully uninstalled setuptools-45.2.0
[2025-05-02T05:08:04.452Z] ERROR: Exception:
[2025-05-02T05:08:04.452Z] Traceback (most recent call last):
[2025-05-02T05:08:04.452Z]   File "/usr/lib/python3.9/py_compile.py", line 144, in compile
[2025-05-02T05:08:04.452Z]     code = loader.source_to_code(source_bytes, dfile or file,
[2025-05-02T05:08:04.452Z]   File "<frozen importlib._bootstrap_external>", line 918, in source_to_code
[2025-05-02T05:08:04.452Z]   File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
[2025-05-02T05:08:04.452Z]   File "/usr/local/lib/python3.9/dist-packages/pytype/tools/merge_pyi/test_data/parse_error.py", line 2
[2025-05-02T05:08:04.452Z]     def f(*): pass
[2025-05-02T05:08:04.452Z]            ^
[2025-05-02T05:08:04.452Z] SyntaxError: named arguments must follow bare *
[2025-05-02T05:08:04.452Z] 
[2025-05-02T05:08:04.452Z] During handling of the above exception, another exception occurred:
[2025-05-02T05:08:04.452Z] 
[2025-05-02T05:08:04.452Z] Traceback (most recent call last):
[2025-05-02T05:08:04.452Z]   File "/usr/lib/python3.9/compileall.py", line 238, in compile_file
[2025-05-02T05:08:04.452Z]     ok = py_compile.compile(fullname, cfile, dfile, True,
[2025-05-02T05:08:04.452Z]   File "/usr/lib/python3.9/py_compile.py", line 150, in compile
[2025-05-02T05:08:04.452Z]     raise py_exc
[2025-05-02T05:08:04.452Z] py_compile.PyCompileError:   File "/usr/local/lib/python3.9/dist-packages/pytype/tools/merge_pyi/test_data/parse_error.py", line 2
[2025-05-02T05:08:04.452Z]     def f(*): pass
[2025-05-02T05:08:04.452Z]            ^
[2025-05-02T05:08:04.452Z] SyntaxError: named arguments must follow bare *
[2025-05-02T05:08:04.452Z] 
[2025-05-02T05:08:04.452Z] 
[2025-05-02T05:08:04.452Z] During handling of the above exception, another exception occurred:
[2025-05-02T05:08:04.452Z] 
[2025-05-02T05:08:04.452Z] Traceback (most recent call last):
[2025-05-02T05:08:04.452Z]   File "/usr/local/lib/python3.9/dist-packages/pip/_internal/cli/base_command.py", line 105, in _run_wrapper
[2025-05-02T05:08:04.452Z]     status = _inner_run()
[2025-05-02T05:08:04.452Z]   File "/usr/local/lib/python3.9/dist-packages/pip/_internal/cli/base_command.py", line 96, in _inner_run
[2025-05-02T05:08:04.452Z]     return self.run(options, args)
[2025-05-02T05:08:04.452Z]   File "/usr/local/lib/python3.9/dist-packages/pip/_internal/cli/req_command.py", line 68, in wrapper
[2025-05-02T05:08:04.452Z]     return func(self, options, args)
[2025-05-02T05:08:04.452Z]   File "/usr/local/lib/python3.9/dist-packages/pip/_internal/commands/install.py", line 459, in run
[2025-05-02T05:08:04.452Z]     installed = install_given_reqs(
[2025-05-02T05:08:04.452Z]   File "/usr/local/lib/python3.9/dist-packages/pip/_internal/req/__init__.py", line 83, in install_given_reqs
[2025-05-02T05:08:04.452Z]     requirement.install(
[2025-05-02T05:08:04.452Z]   File "/usr/local/lib/python3.9/dist-packages/pip/_internal/req/req_install.py", line 867, in install
[2025-05-02T05:08:04.452Z]     install_wheel(
[2025-05-02T05:08:04.452Z]   File "/usr/local/lib/python3.9/dist-packages/pip/_internal/operations/install/wheel.py", line 728, in install_wheel
[2025-05-02T05:08:04.452Z]     _install_wheel(
[2025-05-02T05:08:04.452Z]   File "/usr/local/lib/python3.9/dist-packages/pip/_internal/operations/install/wheel.py", line 614, in _install_wheel
[2025-05-02T05:08:04.452Z]     success = compileall.compile_file(path, force=True, quiet=True)
[2025-05-02T05:08:04.452Z]   File "/usr/lib/python3.9/compileall.py", line 255, in compile_file
[2025-05-02T05:08:04.452Z]     msg = err.msg.encode(sys.stdout.encoding,
[2025-05-02T05:08:04.452Z] TypeError: encode() argument 'encoding' must be str, not None
[2025-05-02T05:08:04.452Z]

KumoLiu · 2025-05-02T10:30:41Z

/build

Signed-off-by: Eric Kerfoot <[email protected]>

ericspod · 2025-05-02T12:11:04Z

The blossom issue is related to the current pytype version, so I've added <=2024.4.11 to the requirements-dev.txt file for it.

KumoLiu · 2025-05-02T12:12:31Z

/build

KumoLiu · 2025-05-02T13:22:17Z

The blossom issue is related to the current pytype version, so I've added <=2024.4.11 to the requirements-dev.txt file for it.

Seems related to the new version of the pip: https://pypi.org/project/pip/#history
I tried downgrade it to 25.0.1, then it works.

raise issue here: google/pytype#1909

Updates for Pytorch 2.7

0550ce8

Signed-off-by: Eric Kerfoot <[email protected]>

ericspod requested review from Copilot, Nic-Ma and KumoLiu April 25, 2025 11:38

Copilot AI reviewed Apr 25, 2025

View reviewed changes

pyproject.toml Show resolved Hide resolved

.github/workflows/pythonapp.yml Show resolved Hide resolved

.github/workflows/pythonapp-min.yml Show resolved Hide resolved

Type fix?

00a2dba

Signed-off-by: Eric Kerfoot <[email protected]>

KumoLiu reviewed Apr 25, 2025

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

Remove py38 reference

c978eae

Signed-off-by: Eric Kerfoot <[email protected]>

ericspod mentioned this pull request Apr 28, 2025

Illegal Instruction Caused by grid_sample Under Windows pytorch/pytorch#152385

Open

ericspod and others added 8 commits April 30, 2025 11:08

Try a fix for Windows issue

f990ccc

Signed-off-by: Eric Kerfoot <[email protected]>

Try a fix for Windows issue

bb15b1f

Signed-off-by: Eric Kerfoot <[email protected]>

Try a fix for Windows issue

d10f518

Signed-off-by: Eric Kerfoot <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

a1f8df9

for more information, see https://pre-commit.ci

Updates to test precision to account for float32 conversion, this sho…

d2cc08f

…uld be removed when PyTorch is updated. Signed-off-by: Eric Kerfoot <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

2dc1b31

for more information, see https://pre-commit.ci

autofix

054bcdc

Signed-off-by: Eric Kerfoot <[email protected]>

Merge branch 'torch27' of github.com:ericspod/MONAI into torch27

405b14a

Signed-off-by: Eric Kerfoot <[email protected]>

Remove extra file

5a537cd

Signed-off-by: Eric Kerfoot <[email protected]>

Attempt pytype fix

b3b1c38

Signed-off-by: Eric Kerfoot <[email protected]>

ericspod mentioned this pull request May 2, 2025

Restrict PyTorch Version to Below 2.7 #8436

Open

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates for Pytorch 2.7 #8429

Updates for Pytorch 2.7 #8429

ericspod commented Apr 25, 2025

Copilot AI left a comment

ericspod commented Apr 25, 2025

ericspod commented Apr 25, 2025

ericspod commented Apr 28, 2025

KumoLiu commented Apr 29, 2025

ericspod commented Apr 29, 2025

KumoLiu commented Apr 30, 2025 •

edited

Loading

ericspod commented May 1, 2025

KumoLiu commented May 2, 2025

KumoLiu commented May 2, 2025

KumoLiu commented May 2, 2025

ericspod commented May 2, 2025

KumoLiu commented May 2, 2025

KumoLiu commented May 2, 2025 •

edited

Loading

Updates for Pytorch 2.7 #8429

Are you sure you want to change the base?

Updates for Pytorch 2.7 #8429

Conversation

ericspod commented Apr 25, 2025

Description

Types of changes

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

ericspod commented Apr 25, 2025

ericspod commented Apr 25, 2025

ericspod commented Apr 28, 2025

KumoLiu commented Apr 29, 2025

ericspod commented Apr 29, 2025

KumoLiu commented Apr 30, 2025 • edited Loading

ericspod commented May 1, 2025

KumoLiu commented May 2, 2025

KumoLiu commented May 2, 2025

KumoLiu commented May 2, 2025

ericspod commented May 2, 2025

KumoLiu commented May 2, 2025

KumoLiu commented May 2, 2025 • edited Loading

KumoLiu commented Apr 30, 2025 •

edited

Loading

KumoLiu commented May 2, 2025 •

edited

Loading