Fix button layout of manual process form#543
Conversation
… fontawesome icon to the reload button Project60#430
…at align with the general civicrm styling
There was a problem hiding this comment.
Thanks for your contribution @knottheory! I could only have a quick look and wasn't able to test the PR.
I'm not sure I like the onclick attributes on the new buttons, thus not approving this PR right away. If it's just about layout, this should use a CSS-only approach.
|
Thanks for reviewing my PR @jensschuppe. Could you elaborate on why you don't like the Usually I would agree with the css-only approach, however in this case I thought it would be easier to update the template to align with the current civi templates. This way the default civi css is applied. No new css needs to be written and the styling is more aligned with the rest of CiviCRM. Many Thanks in advance. |
jensschuppe
left a comment
There was a problem hiding this comment.
Could you elaborate on why you don't like the
onclickattribute? As I see it theonlickproperty was not changed and only moved to a button element instead of an anchor.
I was talking about the onclick="location.href='…'" ones instead of an <a href="…"> - but obviously, there's a lot to consider for refactoring in this template and it already has onclick attributes all over the place, so I don't want to delay the improvements this PR makes because of that.
I still didn't actually test the UI so approving the PR concept-wise solely from looking at the code - except for the leftover console.log() calls, please remove those before we merge this.
|
Thanks for the collaboration. I will review the code tomorrow and adjust the PR. |
The new manual processing layout:
Fixes issue: #430