Skip to content

Added documentation about SEPA matcher#546

Open
CS-DaS wants to merge 4 commits into
Project60:masterfrom
CS-DaS:documentation-sepa-matcher
Open

Added documentation about SEPA matcher#546
CS-DaS wants to merge 4 commits into
Project60:masterfrom
CS-DaS:documentation-sepa-matcher

Conversation

@CS-DaS

@CS-DaS CS-DaS commented Jul 15, 2026

Copy link
Copy Markdown

No description provided.

@dontub dontub left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CS-DaS! Can you have a look at my comments?

Comment thread docs/configuration/plugins/analyser-matcher.md Outdated
Comment thread docs/configuration/plugins/analyser-matcher.md Outdated
and use only one contribution to create one suggestion.

A typical value for `sepa_mandate` would be `SEPA-1-RCUR-2026-RW85J34H14Z`,
which is the reference of a CiviCRM SepaMandate. A typical value for

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
which is the reference of a CiviCRM SepaMandate. A typical value for
which is the reference of a CiviCRM `SepaMandate`. A typical value for

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if "CiviCRM" could be interpreted as SepaMandate belonging to CiviCRM Core...

Probably it should be noted at the beginning that this matcher is about SEPA mandates from the CiviSEPA extension.

Comment thread docs/configuration/plugins/analyser-matcher.md Outdated
Comment thread docs/configuration/plugins/analyser-matcher.md Outdated
Comment thread docs/configuration/plugins/analyser-matcher.md Outdated
Comment thread docs/configuration/plugins/analyser-matcher.md Outdated
@dontub dontub added documentation status:needs work There is code, but it needs additional work before it should be reviewed labels Jul 23, 2026
@dontub dontub self-assigned this Jul 23, 2026
@CS-DaS

CS-DaS commented Jul 23, 2026

Copy link
Copy Markdown
Author

Thanks for your feedback! I did all the corrections.

@CS-DaS
CS-DaS requested a review from dontub July 23, 2026 16:16
@dontub

dontub commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Thanks for your feedback! I did all the corrections.

Thanks! I think it should be explicitly stated that this matcher depends on CiviSEPA. If just CiviBanking is installed there's no SepaMandate and it might be unclear where it comes from.

@CS-DaS

CS-DaS commented Jul 24, 2026

Copy link
Copy Markdown
Author

Good idea. I added the dependency on CiviSEPA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation status:needs work There is code, but it needs additional work before it should be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants