Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract usePlugins for additive plugins. #4029

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Extract usePlugins for additive plugins. #4029

wants to merge 1 commit into from

Conversation

cbeer
Copy link
Collaborator

@cbeer cbeer commented Dec 11, 2024

Instead of relying on the withPlugins HOC to pass in the add plugins, we can use the usePlugins hook to do this instead. This is a little more explicit and hopefully easier to understand (and perhaps allows for multiple pluggable areas for a component?)

@cbeer cbeer force-pushed the usePlugins branch 2 times, most recently from 57d48fe to 4b9afb6 Compare February 28, 2025 22:17
@cbeer cbeer marked this pull request as ready for review February 28, 2025 22:50
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 98.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.92%. Comparing base (f22e042) to head (5b099fd).

Files with missing lines Patch % Lines
src/components/WindowTopMenu.jsx 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4029      +/-   ##
==========================================
- Coverage   94.93%   94.92%   -0.01%     
==========================================
  Files         323      324       +1     
  Lines       16135    16152      +17     
  Branches     2540     2538       -2     
==========================================
+ Hits        15318    15333      +15     
- Misses        812      814       +2     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant