-
Notifications
You must be signed in to change notification settings - Fork 6
Pre-ran key-figures.ipynb; change JB execution to auto #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
Yay it ran! But I will need to re-run locally, since I had interrupted one of the (long) Dask compute cells after mistakenly re-running it. I also will add some Markdown warning users who want to run it on their own that the notebook will take a long time to run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great in the preview!
Whoops didn't see this. Makes sense to add the warning to users! I also think we should leave an open issue in the repo re: the aspirational goal of having the whole Cookbook executed during regular health checks. |
looks like NCAR just changed some URL's! New one for LENS CESM looks to be https://www.cesm.ucar.edu/community-projects/lens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the one interrupted cell, looks good!
Is that interrupted cell supposed to be there? I'm a bit confused about that. |
Thought I had pushed the version that had the interrupted cell resolved. I will try again ... |
My guess is that this may be an unintended misbehavior in Jupyterbook with the |
hmm you may be right. There's another possible strategy: We can specific particular files to be excluded from execution at build time: Maybe if we set |
Could be ... wonder if that will either:
I think I'll try building the book locally to see what happens before pushing. Otherwise, seems the only option would be to do a push where the notebook is temporarily removed, then add it back and push again. |
It all seemed to work this time:
I think/hope/pray if we merge, the JB-rendered version will look good as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ktyle I do see the updated preview, and it looks great!
I think this is good to go. Thanks for your dogged efforts on this.
Oh yeah I see it now on the preview as well! I was too impatient I guess. I will merge! 😺 |
Correction, thanks for your catted efforts on this. |
😹 |
Addresses #3 . Let's see if everything builds properly ... the fully-run key-figures notebook should not get re-run since Jupyter Book execution is set to auto.