Skip to content

Use binder -- can we run the big notebook? #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 16, 2023

Conversation

brian-rose
Copy link
Member

Does the new Pythia binder resolve #3 ?

@github-actions
Copy link

github-actions bot commented Jun 15, 2023

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 32a5e1d
✅ Deployment Preview URL: https://ProjectPythia.github.io/cesm-lens-aws-cookbook/_preview/16

@brian-rose
Copy link
Member Author

The build is erroring out with

asyncio.exceptions.TimeoutError

same as I found over at ProjectPythia/na-cordex-viz-cookbook#4

I guess there is a timeout limit specfied somewhere, I will investigate.

@ktyle
Copy link
Contributor

ktyle commented Jun 15, 2023

It looks like some additional infrastructre is necessary in order to provide Dask capabilities. https://www.zonca.dev/posts/2022-04-04-dask-gateway-jupyterhub.html

@brian-rose
Copy link
Member Author

Yes, the binderbot CLI has an input option --nb-timeout that defaults to 600 seconds.

We don't currently have an option to modify this default in our build workflow, but I will add this.

@brian-rose
Copy link
Member Author

It looks like some additional infrastructre is necessary in order to provide Dask capabilities. https://www.zonca.dev/posts/2022-04-04-dask-gateway-jupyterhub.html

Both this notebook and the one in https://github.com/ProjectPythia/na-cordex-viz-cookbook run interactively on the Pythia binder, they just take a while.

Both notebooks use Dask but only with distributed.LocalCluster.

Using Dask Gateway to dynamically spin up big worker clusters would be a big asset, but it seems like there are some technical barriers to implementing this capability on JetStream2. We budgeted to develop this capability in our under-review NSF grant.

@brian-rose
Copy link
Member Author

I'm going to try implementing a longer timeout on binderbot for this repo. I think it needs upward of 1 hour of wall time.

Assuming that works, I might change the "nightly build" to a "weekly build" -- this could be a good model for resource-intensive Cookbooks.

@brian-rose
Copy link
Member Author

Fixed one obsolete bit of code that raised exceptions during interactive run.

Set a new flag to allow notebook execution up to one hour on the binder.

Changed the cron schedule for the nightly-build.yaml to weekly rather than nightly.

Let's see if this builds successfully!

@brian-rose
Copy link
Member Author

If this works, then we can close #3

@brian-rose
Copy link
Member Author

Yay, it works!

@brian-rose brian-rose marked this pull request as ready for review June 15, 2023 21:55
@brian-rose brian-rose requested review from ktyle and r-ford June 15, 2023 21:55
@brian-rose
Copy link
Member Author

@ktyle @r-ford any comments before merging this?

The cookbook is now fully reproducing.

@brian-rose brian-rose merged commit 3edcf7c into ProjectPythia:main Jun 16, 2023
@brian-rose brian-rose deleted the use-binder branch June 16, 2023 01:05
github-actions bot pushed a commit that referenced this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculations in key-figures.ipynb take too long
2 participants