Build all notebooks via Binderbot #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is read to go I think. I will merge now and test. It should be fully backwards compatible so won't break any existing cookbooks. We'll see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
build_book.yamlworkflow to use binderbot to execute all notebooks in the repo.This is a key part of the solution to ProjectPythia/cookbook-template#89. We abstract away almost all the implementation to this centralized repo.
The execution occurs on the Binder specified in the cookbooks's
_config.yml. This is by design the same Binder that the Cookbook's "launch" buttons link to.Currently, we just execute every *.ipynb file in the repo. It would be better to cross-reference against the
_toc.ymlfile to avoid executing notebooks that are in the repo but not included in the book (a waste of compute, and the result will never be visible anyway).A question I will bring up at the IWG: should executing via a Binder be required, or optional (i.e. should there be a switch in each Cookbook repo)?