-
Notifications
You must be signed in to change notification settings - Fork 4
make workflows match template #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jukent this all looks good except the environment name that gets passed to the build-book action in several places. I think this passed tests only because it was using a cached version of the build environment.
Co-authored-by: Brian Rose <[email protected]>
Co-authored-by: Brian Rose <[email protected]>
Co-authored-by: Brian Rose <[email protected]>
I'll look for that in the other PRs too @brian-rose in the other cookbooks, the environment name is just "cookbook-dev" so nothing else needs to be changed in the workflows. Is there a reason to give it a repo specific name? |
I think it's a decision for individual cookbook authors to make. The reason is to disambiguate that environment from any number of other cookbook environments that an individual might have installed locally. |
Makes sense. |
ProjectPythia/cookbook-gallery#96 (comment)