Skip to content

make workflows match template #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 21, 2022
Merged

make workflows match template #22

merged 6 commits into from
Nov 21, 2022

Conversation

jukent
Copy link
Contributor

@jukent jukent commented Nov 21, 2022

@github-actions
Copy link

github-actions bot commented Nov 21, 2022

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 52c618f
✅ Deployment Preview URL: https://ProjectPythiaCookbooks.github.io/intake-cookbook/_preview/22

Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jukent this all looks good except the environment name that gets passed to the build-book action in several places. I think this passed tests only because it was using a cached version of the build environment.

@jukent
Copy link
Contributor Author

jukent commented Nov 21, 2022

I'll look for that in the other PRs too


@brian-rose in the other cookbooks, the environment name is just "cookbook-dev" so nothing else needs to be changed in the workflows. Is there a reason to give it a repo specific name?

@jukent jukent requested a review from brian-rose November 21, 2022 17:44
@brian-rose
Copy link
Member

@brian-rose in the other cookbooks, the environment name is just "cookbook-dev" so nothing else needs to be changed in the workflows. Is there a reason to give it a repo specific name?

I think it's a decision for individual cookbook authors to make. The reason is to disambiguate that environment from any number of other cookbook environments that an individual might have installed locally.

@jukent
Copy link
Contributor Author

jukent commented Nov 21, 2022

Makes sense.

@jukent jukent merged commit 0345c9c into ProjectPythia:main Nov 21, 2022
github-actions bot pushed a commit that referenced this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants