Skip to content

Address #349: Fix broken links to the Pythia team in a few places #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 2, 2024

Conversation

erogluorhan
Copy link
Member

@erogluorhan erogluorhan commented Dec 21, 2023

Closes #349

The places that were pointed out in the issue 349 (i.e. "The Project Team" in the page footer and in the Who is Project Pythia section of the About page) have already been accidentally merged via this commit last week.

This PR additionally fixed a link in the "Join us!" part in index.md. Additional search for the "team" did not return any links to the formerly removed team part in index.md.

So, all changes that need to be done for the team links should be done now.

Copy link
Contributor

github-actions bot commented Dec 21, 2023

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 1f7250f
✅ Deployment Preview URL: https://projectpythia.github.io/_preview/375

@erogluorhan erogluorhan marked this pull request as ready for review December 21, 2023 03:13
@erogluorhan erogluorhan requested a review from a team as a code owner December 21, 2023 03:13
@erogluorhan erogluorhan requested review from brian-rose and dcamron and removed request for a team December 21, 2023 03:13
@dcamron
Copy link
Contributor

dcamron commented Dec 27, 2023

Is this still in progress? I don't see the changes described in your post in your commits.

@erogluorhan
Copy link
Member Author

Is this still in progress? I don't see the changes described in your post in your commits.

Looks like those changes have already been accidentally merged via this commit last week (i.e. the rendered portal already has those changes show up). I've added this information to the PR description.

I think we should be good with this PR.

@brian-rose brian-rose merged commit 69bff73 into main Jan 2, 2024
@brian-rose brian-rose deleted the issue_349 branch January 2, 2024 16:19
github-actions bot pushed a commit that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken internal links to the (missing) Team section
3 participants