Skip to content

Fix broken links #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 6, 2025
Merged

Fix broken links #504

merged 4 commits into from
Mar 6, 2025

Conversation

brian-rose
Copy link
Member

The nightly build has been failing for months due to link problems. This PR should get it passing again.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Mar 6, 2025

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 08499f2
✅ Deployment Preview URL: https://ProjectPythia.github.io/pythia-foundations/_preview/504

@brian-rose brian-rose closed this Mar 6, 2025
@brian-rose brian-rose reopened this Mar 6, 2025
@brian-rose
Copy link
Member Author

The link checker seems to be checking the unmodified sources instead of the modified sources in the PR. I have no idea why.

@brian-rose
Copy link
Member Author

The link checker seems to be checking the unmodified sources instead of the modified sources in the PR. I have no idea why.

Nope, it was user error, I didn't catch all the offending links in my previous commits. Should be good to go now.

@brian-rose
Copy link
Member Author

Note to whoever reviews this, the MATLAB links are not broken but they are refusing our link checker. If we kept the links, we would have to add explicit exceptions to the link checker, like we do in the Cookbook template.

Getting rid of links to MATLAB seemed like a simpler and better solution.

@brian-rose brian-rose marked this pull request as ready for review March 6, 2025 16:51
@brian-rose brian-rose requested a review from a team as a code owner March 6, 2025 16:51
@brian-rose brian-rose requested review from clyne and jukent and removed request for a team March 6, 2025 16:51
@clyne clyne merged commit 83ec633 into ProjectPythia:main Mar 6, 2025
3 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 6, 2025
@brian-rose brian-rose deleted the fix-links branch March 6, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants