-
Notifications
You must be signed in to change notification settings - Fork 46
Fix broken links #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken links #504
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
The link checker seems to be checking the unmodified sources instead of the modified sources in the PR. I have no idea why. |
Nope, it was user error, I didn't catch all the offending links in my previous commits. Should be good to go now. |
Note to whoever reviews this, the MATLAB links are not broken but they are refusing our link checker. If we kept the links, we would have to add explicit exceptions to the link checker, like we do in the Cookbook template. Getting rid of links to MATLAB seemed like a simpler and better solution. |
The nightly build has been failing for months due to link problems. This PR should get it passing again.