Skip to content

Fix Binder links #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 11, 2022
Merged

Fix Binder links #63

merged 4 commits into from
Aug 11, 2022

Conversation

brian-rose
Copy link
Member

Addresses ProjectPythia/cookbook-gallery#85 for this repo.

@github-actions
Copy link

github-actions bot commented Aug 11, 2022 •
edited
Loading

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 7d1e4af
✅ Deployment Preview URL: https://ProjectPythiaCookbooks.github.io/radar-cookbook/_preview/63

@mgrover1
Copy link
Contributor

@brian-rose I think we can use https://aws-uswest2-binder.pangeo.io.. it just requires people have a github account

@brian-rose
Copy link
Member Author

@mgrover1 no problem, if you want to try that for this Cookbook! At today's IWG we decided that it was top priority to get the broken links fixed, and mybinder.org was path of least resistance.

I'll update this PR to use https://aws-uswest2-binder.pangeo.io/ instead, it will be good to experiment with it.

@brian-rose brian-rose changed the title Update _config.yml Fix Binder links Aug 11, 2022
@mgrover1
Copy link
Contributor

Thanks @brian-rose !!

@brian-rose brian-rose requested a review from mgrover1 August 11, 2022 19:10
@mgrover1
Copy link
Contributor

@brian-rose currently testing it to make sure the binder builds

mgrover1
mgrover1 approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brian-rose for taking care of this! Looks like it runs :)

@mgrover1 mgrover1 merged commit f86d5e8 into main Aug 11, 2022
@mgrover1 mgrover1 deleted the fix-binder-link branch August 11, 2022 19:20
github-actions bot pushed a commit that referenced this pull request Aug 11, 2022
@mgrover1 @github-actions
Delete preview for pull request \#63
7014cc1
@brian-rose brian-rose mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrover1 mgrover1 mgrover1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brian-rose @mgrover1