Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

Update replace_step.js#19

Closed
jindw wants to merge 2 commits into
ProseMirror:masterfrom
jindw:master
Closed

Update replace_step.js#19
jindw wants to merge 2 commits into
ProseMirror:masterfrom
jindw:master

Conversation

@jindw
Copy link
Copy Markdown

@jindw jindw commented Oct 22, 2021

fix gap range : gapFrom = min(from,gapFrom), gapTo=max(to,gapTo)


if the external boundary is reached, there will be no deletion, right?Are there any other ignored problems?

fix gap range  : gapFrom = min(from,gapFrom), gapTo=max(to,gapTo)
@marijnh
Copy link
Copy Markdown
Member

marijnh commented Oct 24, 2021

What problem does this patch solve?

@jindw
Copy link
Copy Markdown
Author

jindw commented Oct 25, 2021

What problem does this patch solve?

ReplaceAroundStep data loss during offline collaborative editing [#1216]

Copy link
Copy Markdown
Author

@jindw jindw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the first patch has a low-level syntax error:

line 146

if ((from.deleted && to.deleted) return null

fixed to:

if (from.deleted && to.deleted) return null

@marijnh marijnh closed this Mar 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants