- 
                Notifications
    
You must be signed in to change notification settings  - Fork 478
 
Changing APIs to use object parameters #1037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            Pauan
  wants to merge
  24
  commits into
  ProvableHQ:mainnet
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
Pauan:feat/object-params
  
      
      
   
  
    
  
  
  
 
  
      
    base: mainnet
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been on the list to do, I'll ensure this gets proper review shortly.
42eab92    to
    eb3e621      
    Compare
  
    50c76b5    to
    d5191d1      
    Compare
  
    d9c075a    to
    cf02148      
    Compare
  
    99c2314    to
    185e647      
    Compare
  
    185e647    to
    45d498e      
    Compare
  
    45d498e    to
    aaf9bfe      
    Compare
  
    …ForTransactionConfirmation to use object params
* ProgramManager * checkFee * buildDeploymentTransaction * deploy * run * join * split * synthesizeKeys * buildTransferTransaction * buildTransferPublicTransaction * buildTransferPublicAsSignerTransaction * transfer * buildBondPublicTransaction * bondPublic * buildBondValidatorTransaction * bondValidator * buildUnbondPublicTransaction * unbondPublic * buildClaimUnbondPublicTransaction * claimUnbondPublic * buildSetValidatorStateTransaction * setValidatorState * verifyExecution * getCreditsRecord
* findCreditsRecords * findCreditsRecord * findRecord * findRecords * BlockHeightSearch
aaf9bfe    to
    35b9ce2      
    Compare
  
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
As the methods have become more complex, they've gotten a lot of arguments.
This PR refactors them to use an object instead of arguments.
Old:
New:
This has a few benefits:
undefinedfor fields that you aren't using.These are the APIs that have been changed:
AccountfromCiphertextverifyWorkerAPIrunFunctionKeyProviderfetchRemoteKeysfetchProvingKeyOfflineKeyProviderverifyCreditsKeysAleoNetworkClientconstructorfindRecordsfindUnspentRecordsgetProgramMappingValuegetProgramMappingPlaintextwaitForTransactionConfirmationgetBlockRangeProgramManagerconstructorcheckFeebuildDeploymentTransactiondeployrunjoinsplitsynthesizeKeysbuildTransferTransactionbuildTransferPublicTransactionbuildTransferPublicAsSignerTransactiontransferbuildBondPublicTransactionbondPublicbuildBondValidatorTransactionbondValidatorbuildUnbondPublicTransactionunbondPublicbuildClaimUnbondPublicTransactionclaimUnbondPublicbuildSetValidatorStateTransactionsetValidatorStateverifyExecutiongetCreditsRecordNetworkRecordProviderconstructorfindCreditsRecordsfindCreditsRecordfindRecordfindRecordsBlockHeightSearchconstructor