Update GetDataHandlers.cs #2852
Conversation
Fixed syntax errors.
|
As originally requested in #2823, please don't include changes to number of PVE/PVP deaths, as that will be dealt with in #2768 Commits and changes are still a bit scattered, and it's not super clear which issues this PR solves -- can you update the description to include the specific issues that this PR solves? |
1.Fixed wrong MaxProjDamage trigger. |
|
@ATFGK I'm not sure I understand that last issue -- can you describe it further or show an example? |
It has little impact on "Tshock", but the wrong "SpawnContext" message will cause a lot of problems for other plug-ins because they cannot correctly recognize "SpawnContext" |
"Tshock" also uses a lot of "TSPlayer. Spawn()", so other plug-ins cannot avoid receiving incorrect "SpawnContext" |
|
Yeah, totally see the issue and understand. With that other PR blocked for non-working, I'm fine accepting these changes first, even if it means the other PR will get conflicts. I'll review this ASAP. |
drunderscore
left a comment
drunderscore
left a comment
There was a problem hiding this comment.
All the code looks good -- just some code smell and grammatical issues otherwise!
Use insteadUpperCamelCase
Missing letters due to input method problems.
There was a problem hiding this comment.
Unfortunately the changelog quality is still quite lacking -- so instead of holding this PR up for any longer due to it's non-conforming changelog, please copy the changelog entries from this changelog file into yours.
|
To make it even easier, I've created a pull request on your repository for this branch with the correct changes. |
Correct changelog entries for Pryaxis/TShock Pryaxis#2852
Thank you very much for your help. :-D |
) * update * update * update * Update changelog.md * Update changelog.md Fixed syntax errors. * Update SpawnMsg.cs Use insteadUpperCamelCase * Update changelog.md * Update TSPlayer.cs * Update TSPlayer.cs Missing letters due to input method problems. * Update `docs/changelog.md` Co-authored-by: James Puleo <[email protected]>
3 participants
Fixes #2804
Fix GetDataHandlers.cs file for version 144X, and correct various errors caused by it.