Added implementation for the actual conversion #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inserted an analytics script placeholder (`__ANALYTICS_SCRIPT__`) in the `_Layout.cshtml` file before the closing `</head>` tag to facilitate future tracking and monitoring integration.
Updated `PxApiConverter.csproj` to include an `ItemGroup` that specifies `Views\Shared\_Layout.cshtml` to be copied to the output directory during the build process.
Added a comment to `PxApiConverter.csproj` to ensure source views are included. Modified the `<Content>` item group to include all `.cshtml` files in the `Views` directory and its subdirectories, replacing the specific entry for `_Layout.cshtml`. This change ensures all view files are copied to the publish directory during the build process.
Added `<EnableDefaultContentItems>false</EnableDefaultContentItems>` to the `<PropertyGroup>` in `PxApiConverter.csproj`. Removed a comment about source views and added the closing `<Project>` tag.
The code block responsible for constructing the `dataUrl` string in the `PxApiConverter.Business` namespace has been removed. This includes the logic for appending the base URL, table ID, language, and output format, as well as handling optional `outputFormatParams`. This change likely reflects a shift in how `dataUrl` is constructed or utilized elsewhere in the codebase.
Modified `ConvertUtil.cs` to replace `variableCodes` with `valueCodes` in query parameter construction, aligning with updated parameter naming conventions. Updated `Program.cs` to replace the hardcoded database path with a configurable value from the application settings, improving flexibility and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.