Merge pull request #14 from PyCampES/handle_comma

handle comma in description
PyCampES · Mar 31, 2024 · 47fdb66 · 47fdb66
2 parents 66991d4 + 46cd613
commit 47fdb66
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 0 deletions.
diff --git a/src/ficamp/classifier/preprocessing.py b/src/ficamp/classifier/preprocessing.py
@@ -21,11 +21,21 @@ def remove_pipes(s: str) -> str:
     return " ".join(s.split("|"))
 
 
+def remove_colon(s: str) -> str:
+    return " ".join(s.split(":"))
+
+
+def remove_comma(s: str) -> str:
+    return " ".join(s.split(","))
+
+
 def preprocess(s: str) -> str:
     "Clean up transaction description"
     steps = (
         lambda s: s.lower(),
         remove_pipes,
+        remove_colon,
+        remove_comma,
         remove_digits,
     )
     out = s

diff --git a/tests/test_preprocessing.py b/tests/test_preprocessing.py
@@ -2,6 +2,8 @@
 
 from ficamp.classifier.preprocessing import (
     preprocess,
+    remove_colon,
+    remove_comma,
     remove_digits,
     remove_pipes,
 )
@@ -35,6 +37,25 @@ def test_remove_pipes(inp, exp):
     assert remove_pipes(inp) == exp
 
 
+@pytest.mark.parametrize(
+    ("inp,exp"),
+    (
+        ("CSIDNL0213324324324", "CSIDNL0213324324324"),
+        ("CSID:NL0213324324324", "CSID NL0213324324324"),
+    ),
+)
+def test_remove_colon(inp, exp):
+    assert remove_colon(inp) == exp
+
+
+@pytest.mark.parametrize(
+    ("inp,exp"),
+    (("CSID,NL0213324324324", "CSID NL0213324324324"),),
+)
+def test_remove_comma(inp, exp):
+    assert remove_comma(inp) == exp
+
+
 @pytest.mark.parametrize(
     ("inp,exp"),
     (
@@ -47,6 +68,8 @@ def test_remove_pipes(inp, exp):
         ("SEPA 12312321 bic", "sepa bic"),
         ("SEPA 12312321 123BIC", "sepa"),
         ("SEPA 1231|AMSTERDAM 123BIC", "sepa amsterdam"),
+        ("CSID:NL0213324324324", "csid"),
+        ("CSID:NL0213324324324 HELLO,world1332", "csid hello"),
     ),
 )
 def test_preprocess(inp, exp):