fix lint warning with Rust 1.87 #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icxolu
reviewed
May 18, 2025
There was a problem hiding this comment.
I'm definitely in favor of eliding the lifetimes. But just to mention it: This was explicitly allowed for now
Line 39 in 66c7935
Not sure what the history of that is.
(Generally we should move the lint config into Cargo.toml or lib.rs so that it get's picked up by rust-analyzer automatically)
davidhewitt
changed the title
|
Ah thanks, I'd missed that. I've reset the branch to move the config into |
Icxolu
approved these changes
May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the CI lint warning with 1.87. Also elides a bunch of needless named lifetimes at the same time.