Remove extraction from Vec for PyArrayLikeDyn #496
+27
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, sorry for the slow review. CI looks to be falling, though I wonder if it's not actually related... 🤔 @ngoldbaum do I recall something about numpy removing support for Windows x86? Did that happen? |
|
Nope, and upstream CPython isn't planning to either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #491
There seems to be a minor breaking change with this fix where some conversions to
PyArrayLikeDynmay now requireAllowTypeChangewhere it wasn't needed previously (which can be seen in the modified test). It seems like this is the correct behavior to me, since the element type is changing, and this makes the behavior in line with conversions from dynamic arrays of higher dimensionality. Still breaking so I'm open to discussion on whether this is the right call or not.I added one extra test that reproduces the issue from #491 and now passes.