Skip to content

Remove extraction from Vec for PyArrayLikeDyn #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jakemoran
Copy link

Resolves #491

There seems to be a minor breaking change with this fix where some conversions to PyArrayLikeDyn may now require AllowTypeChange where it wasn't needed previously (which can be seen in the modified test). It seems like this is the correct behavior to me, since the element type is changing, and this makes the behavior in line with conversions from dynamic arrays of higher dimensionality. Still breaking so I'm open to discussion on whether this is the right call or not.

I added one extra test that reproduces the issue from #491 and now passes.

@davidhewitt
Copy link
Member

Thanks for the PR, sorry for the slow review. CI looks to be falling, though I wonder if it's not actually related... 🤔

@ngoldbaum do I recall something about numpy removing support for Windows x86? Did that happen?

@ngoldbaum
Copy link
Contributor

Nope, and upstream CPython isn't planning to either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trailing singleton dimensions are removed during dtype conversion
3 participants