Skip to content

fix: return empty flat map when container appstruct is null - #372

Closed
santhreal wants to merge 8 commits into
Pylons:mainfrom
santhreal:fix/flatten-dropped-sequence
Closed

fix: return empty flat map when container appstruct is null#372
santhreal wants to merge 8 commits into
Pylons:mainfrom
santhreal:fix/flatten-dropped-sequence

Conversation

@santhreal

@santhreal santhreal commented Jul 18, 2026

Copy link
Copy Markdown

Sequence.flatten hits TypeError when missing=drop sequence absent from appstruct. This PR fixes the regression with a focused test covering the case.

Mapping/Sequence/Tuple flatten assumed a real container when a
missing=drop child was absent from the appstruct, so SchemaNode.flatten
raised TypeError/AttributeError on colander.null (issue Pylons#299).
macos-latest is arm64; setup-python x64 builds abort under Rosetta/gettext.
setup-python has no pypy-3.8 x86 builds on Windows.
@SashankBhamidi

Copy link
Copy Markdown

@santhreal

Copy link
Copy Markdown
Author

@stevepiercy Do you see an option to close this PR?

You could literally just ask to close the pr. Get off the high horse.

@santhreal santhreal closed this Jul 28, 2026
@SashankBhamidi

Copy link
Copy Markdown

You could literally just ask to close the pr. Get off the high horse.

Oh, thanks mate. Much appreciated.

@SashankBhamidi

Copy link
Copy Markdown

Hi, I just realised this is the wrong repo I commented in. Apologies.

@stevepiercy

Copy link
Copy Markdown
Member

You could literally just ask to close the pr. Get off the high horse.

@santhreal your comment is inconsiderate and disrespectful. Please read and follow https://pylonsproject.org/community-code-of-conduct.html.

@SashankBhamidi owned up to his mistake. I'd advise you do the same. Thank you for your consideration.

@santhreal

Copy link
Copy Markdown
Author

You could literally just ask to close the pr. Get off the high horse.

@santhreal your comment is inconsiderate and disrespectful. Please read and follow https://pylonsproject.org/community-code-of-conduct.html.

@SashankBhamidi owned up to his mistake. I'd advise you do the same. Thank you for your consideration.

I apologize, @SashankBhamidi. Sorry for the rude comment.

@stevepiercy

Copy link
Copy Markdown
Member

@santhreal thank you for apologizing.

Would you like to reopen your pull request?

I'd also suggest making all tests pass in the CI checks. Right now there are failures, and backlogged maintainers are highly unlikely to review closed and failing PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants