fix: return empty flat map when container appstruct is null - #372
fix: return empty flat map when container appstruct is null#372santhreal wants to merge 8 commits into
Conversation
Mapping/Sequence/Tuple flatten assumed a real container when a missing=drop child was absent from the appstruct, so SchemaNode.flatten raised TypeError/AttributeError on colander.null (issue Pylons#299).
macos-latest is arm64; setup-python x64 builds abort under Rosetta/gettext.
setup-python has no pypy-3.8 x86 builds on Windows.
You could literally just ask to close the pr. Get off the high horse. |
Oh, thanks mate. Much appreciated. |
|
Hi, I just realised this is the wrong repo I commented in. Apologies. |
@santhreal your comment is inconsiderate and disrespectful. Please read and follow https://pylonsproject.org/community-code-of-conduct.html. @SashankBhamidi owned up to his mistake. I'd advise you do the same. Thank you for your consideration. |
I apologize, @SashankBhamidi. Sorry for the rude comment. |
|
@santhreal thank you for apologizing. Would you like to reopen your pull request? I'd also suggest making all tests pass in the CI checks. Right now there are failures, and backlogged maintainers are highly unlikely to review closed and failing PRs. |
Sequence.flatten hits TypeError when missing=drop sequence absent from appstruct. This PR fixes the regression with a focused test covering the case.