Skip to content

Rewrite core.relax_integer_vars transformation #3586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

emma58
Copy link
Contributor

@emma58 emma58 commented Apr 29, 2025

Fixes # .

Summary/Motivation:

This rewrites the core.relax_integer_vars transformation, modernizing it to our more recent transformation conventions. In particular, it:

Changes proposed in this PR:

  • Rewrites core.relax_integer_vars transformation
  • Adds tests!
  • Adds VarCollector enum to distinguish getting Vars from active expressions vs. using component_data_objects(Var). Naming suggestions are welcome here...

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@emma58 emma58 requested a review from jsiirola April 29, 2025 23:01
@emma58 emma58 requested a review from mrmundt May 12, 2025 22:38
@emma58
Copy link
Contributor Author

emma58 commented May 12, 2025

This is ready for review again, @mrmundt and @jsiirola

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants