-
Notifications
You must be signed in to change notification settings - Fork 546
CSpline - Fix segment function and add utils to constrain parameter calculations #3593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3593 +/- ##
==========================================
+ Coverage 88.83% 88.85% +0.01%
==========================================
Files 888 888
Lines 102172 102338 +166
==========================================
+ Hits 90767 90932 +165
- Misses 11405 11406 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FYI that there is a pretty silly false positive in the typos check right now that I am hoping they'll do a hot patch to fix. I'm monitoring the PR that their team opened (crate-ci/typos#1311) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new class CubicParametersModelData
probably should have some more unit tests, but I won't let that hold up this PR.
Fixes
There was a bug in the segment function in the parameter class. The function is just used for testing and plotting cubic splines, so it is not likely to have affected anything. It's fixed and tests are added that would catch similar future issues.
Summary/Motivation:
This fixes a bug and adds parameter calculation options that allow you to impose certain properties on the cubic spline.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: