[CQT-360] QX simulator outputs invalid states #205
Conversation
…seems not to erase previous elements of 'state', thus we force 'state.data_.clear()' in SparseArray::operator=(const SparseArray& other). Add fmt::formatters for qx::Measurement and qx::SuperposedState. Implement rule of 5 for SparseArray and QuantumState. Implement SparseArray::operator=(const SparseArray& other). Implement operator<< for qx::Measurement and qx::SuperposedState. Fix SparseComplex::SparseComplex(SparseComplex&& other). Remove SparseArray::operator=(MapBasisVectorToSparseComplex map).
… which was not always performing the assignment (only when a check was true, and that check was wrong). Remove rule of 5 for QuantumState, SparseArray and SparseComplex.
|
Testcase: Circuit Results The results would be the same for the circuit where |
Thanks!
I think I added it a few weeks ago with the following idea: whenever the source of the assignment is below epsilon, i.e., not really null but could be considered null, we just set null in the destination. But the code to do the check for null was wrong. I could have fixed that code, but I decided to remove everything altogether. So now an assignment really makes a copy.
Yes, please. I have already prepared it. But I need the expected results. |
Oh beautiful, thanks so much. |
The problem came from
SparseComplex::operator=, which was not always performing the assignment (only when a check was true, and that check was wrong).Implement
operator<<forqx::Measurementandqx::SuperposedState.Add
fmt::formatters forqx::Measurementandqx::SuperposedState.Remove rule of 5 for SparseComplex.
Remove
SparseArray::operator=(MapBasisVectorToSparseComplex).