Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update change log for release #880

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Update change log for release #880

merged 5 commits into from
Nov 11, 2024

Conversation

lbittarello
Copy link
Member

Also closes #874. @mlondschien

@mlondschien
Copy link
Contributor

mlondschien commented Nov 8, 2024

Thanks! Note that this is conservative. If the link is not a log-link (e.g. OLS), the coefficients can be estimated with intercept_ = y[0] and coef_ = np.zeros(p). It's just when the link is a log-link, then intercept_ = +-inf.

@lbittarello
Copy link
Member Author

If the link is not a log-link (e.g. OLS), the coefficients can be estimated

I think that the coefficients can only be estimated for the identity link. There'll be errors for the log, logit and cloglog links. But I'll move the check just in case.

@lbittarello
Copy link
Member Author

I'm investigating downstream CI errors before proceeding with a release.

@lbittarello lbittarello merged commit e5b26e1 into main Nov 11, 2024
22 checks passed
@lbittarello lbittarello deleted the release-3.1.0 branch November 11, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GLM(alpha_search=True, l1_ratio=1, family="binomial").fit(X, np.ones(n)) raises uninformative error message
4 participants