Use 64bit int indexing for F-contiguous case (#235)

Quantco · Mar 27, 2023 · c9dba31 · c9dba31
1 parent 698f1ee
commit c9dba31
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -7,6 +7,13 @@
 Changelog
 =========
 
+3.1.6 - 2022-03-27
+------------------
+
+**Bug fix:**
+
+- We fixed a bug in the dense sandwich product, which would previously segfault for very large F-contiguous matrices.
+
 3.1.5 - 2022-03-20
 ------------------
 

diff --git a/src/tabmat/ext/dense_helpers-tmpl.cpp b/src/tabmat/ext/dense_helpers-tmpl.cpp
@@ -230,7 +230,7 @@ void dense_base${kparallel}(F* R, F* L, F* d, F* out,
         }
         F* L = &Lglobal.get()[omp_get_thread_num()*thresh1d*thresh1d*kratio];
         for (SIZE_T Cii = Ci; Cii < Cimax2; Cii++) {
-            int ii = cols[Cii];
+            SIZE_T ii = cols[Cii];
             %if order == 'F':
                 for (SIZE_T Rkk=Rk; Rkk<Rkmax2; Rkk++) {
                     SIZE_T kk = rows[Rkk];