Fix osx wheel #366
Merged
Fix osx wheel #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 27, 2024
|
@xhochy, I saw that you were recently involved with some PR on the llvm-openmp feedstock. Do you have any idea why the 18.1.6 release seems to have bumped the minimum target version to 10.13? |
|
Recap: we use conda-forge to install some build dependencies (including llvm-openmp). Conda-forge recently bumped the deployment target to 10.13, and the latest version of llvm-openmp was built using macos 10.13. I think the best solution is to use 10.13 as the deployment version. This will avoid more issues with other dependencies. |
MarcAntoineSchmidtQC
requested review from
xhochy,
jtilly and
lbittarello
as code owners
jtilly
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGELOG.rstentry